[15.0] [IMP] partner_risk_insurance: Insure invoices with credit policies

Shide commented 8 months ago

This improvement allows to insure invoices with credit policies that has marked as "Insure invoices".

When a partner is set on an invoice (only out_invoice) and has a credit policy marked as "Insure invoices", the invoice will be marked as "Insured by a Credit Policy" and the policy and company policy will be set on the invoice.

You can filter on the tree view by the "Insured by a Credit Policy" and group by "credit_policy_company_id" out of the box.

Refactors:

Added original creators on the top of some files
Added group (account.group_account_user) to the Insurance page on Partner.
Added myself as a maintainer too
Renamed credit_policy.py to credit_policy_state.py because there is another related model to credit policies in models folder. (Sorry, only added active and insure_invoices fields)

Roadmap:

Be able to print an image on the Insured invoices (this is why i add the the credit.policy.company model)
FWP this and next PRs to v16

Small demo: https://www.loom.com/share/ac1ce65877644820a5ed53ca08fc38cc?sid=0cae7ed3-de3c-45a3-ac62-949457a49ec4

MT-4974 @moduon @rafaelbn @fcvalgar @yajo @edlopen @sergio-teruel please review if you want :)

OCA-git-bot commented 8 months ago

Hi @omar7r, @sergio-teruel, @Daniel-CA, @Tardo, some modules you are maintaining are being modified, check this out!

Shide commented 8 months ago

Reverted the change of license.

Shide commented 8 months ago

Moved credit policy info to the other info tab, Improved tests, short label for insured_with_credit_policy field in move.

OCA-git-bot commented 7 months ago

On my way to merge this fine PR! Prepared branch 15.0-ocabot-merge-pr-355-by-rafaelbn-bump-major, awaiting test results.

OCA-git-bot commented 7 months ago

Congratulations, your PR was merged at 95494ed8a29800cedbfa45f2a01d9048988ae09f. Thanks a lot for contributing to OCA. ❤️

carlosdauden commented 7 months ago

The initial calculation of the new computed stored fields on account.move will provoke long freezes on module update. Please add a pre-init hook pre-creating the DB columns for avoiding this calculation.

carlosdauden commented 7 months ago

Sorry for the late review

pedrobaeza commented 7 months ago

@Shide please check the comments from my colleague. This is taking down any instance updating this module with a medium number of account.move records.

rafaelbn commented 7 months ago

Thank you @carlosdauden @pedrobaeza . @Shide will review your comments of course before porting to 16.

Maybe we should add @carlosdauden as maintainter?

OCA / credit-control

[15.0] [IMP] partner_risk_insurance: Insure invoices with credit policies #355