[IMP] partner_risk_insurance: improve UX

[yajo]

In Odoo 16, upstream has already a credit_limit field in res.partner. That field is coupled with a checkbox named use_partner_credit_limit, which means "this partner doesn't use the default credit limit; it has a specific credit limit".

Those fields were only available to users of groups account.group_account_invoice and account.group_account_readonly, within the Invoicing tab in res.partner form.

Still there's an extra hidden show_credit_limit field which toggles this feature completely. It depends on wether the current company has credit limits enabled.

This module was migrated from previous versions that had none of these features. The result is that, probably by that inertia, UX ended up becoming inconsistent.

Improvements done:

• Fields are relabeled. Their names confused everybody in our UX investigation. They now reflect better their usage.
• The company default credit limit is ignored when the user sets a different credit limit. Before, it was being included in the sum to get the total credit limit for the partner, but that was contrary to the purpose of that field in upstream Odoo. When you check use_partner_credit_limit in upstream Odoo, you don't add an extra credit limit; instead, you replace the default limit by a custom one. That's what we do here now.
• Tests are rewritten because they were exercising that wrong assumption that I just explained.
• It made no sense to ask the user for total, company and insured credit limits. One of those fields could be computed. Since upstream Odoo already has a writable property field credit_limit (already explained), I picked up company_credit_limit to be the computed one.
• company_credit_limit is no longer stored (and therefore not tracked) because it's a company-dependant field. In multi-company partners, the logger became inconsistent otherwise.
• use_partner_credit_limit gets an onchange to trigger its inverse method beforehand, and make UX consistent before hitting save.
• When setting a insurance credit limit higher than the total credit limit, the total is automatically increased, and the company is automatically set to 0.
• All features are hidden if the company didn't enable credit limits. This is consistent with upstream Odoo.
• Permissions are adjusted to match those of upstream Odoo regarding these fields.
• Tests are executed with those new permissions.

Still, a good extra enhancement would be to move all this stuff to the Invoicing tab. But that can be done later after some more investigation.

@moduon MT-4827

[rafaelbn]

Hello @carlosdauden ,

We are trying to improve UX.

Your point of view is really welcome!

Thanks

[yajo]

I pushed a fix to account_credit_control that should fix the builds.

[yajo]

All relabeling suggestions applied.

[yajo]

Can someone merge please?

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-362-by-rafaelbn-bump-major, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 9ca038dc060de029aff72430c0757830fd08ed45. Thanks a lot for contributing to OCA. ❤️