OCA / data-protection

Data Protection
https://github.com/OCA/data-protection/wiki
GNU Affero General Public License v3.0
31 stars 68 forks source link

[9.0][ADD] gdpr_partner_report #1

Closed MiquelRForgeFlow closed 6 years ago

MiquelRForgeFlow commented 6 years ago

This PR adds:

GDPR Partner Report

This module helps a company to identify all the transactions that a specific partner is involved in, with the possibility to export the associated data.

yajo commented 6 years ago

Some questions about module naming:

  1. Should we prefix addons with some shorter convention, such as dp_, or privacy_?
  2. I feel that we should avoid the gdpr_ prefix. Just to put an example, in Spain we had LOPD, then RGPD, then now GDPR. Naming the addon after each acronym would have been a nightmare, and narrowing its reach to just one jurisdiction also seems innecesary (think of those outside UE that want to use it). Isn't it better to stick with the prefix we choose at point 1?
MiquelRForgeFlow commented 6 years ago

Yeah. No problem with renaming, but I want maximum consensus before doing it. I don't want to change the name four times 😏

pedrobaeza commented 6 years ago

My vote for privacy_. We don't want more initials to get confused (dp: decimal precision? :laughing: )

yajo commented 6 years ago

It seems it's most accepted in the google doc; let's use privacy_ then.

I'll do further review after rename, or GH will trash all comments

MiquelRForgeFlow commented 6 years ago

I don't know what fails in Travis, but Runbot is :green_apple: 😎

As you see in the Readme, the xlsx report doesn't work because the pending fix in the odoo.

MiquelRForgeFlow commented 6 years ago

When https://github.com/OCA/data-protection/pull/2 gets merged, then I will open a new PR for the partner report.

dreispt commented 6 years ago

@mreficent no point in waiting, please go ahead asap. You can fix the dependency name for the base module once #1 is sorted out.