search

OCA / data-protection

Data Protection
https://github.com/OCA/data-protection/wiki
GNU Affero General Public License v3.0
31 stars 68 forks source link

GDPR Module for OCA V11 #10

Closed ITISAG-OCA closed 6 years ago

ITISAG-OCA commented 6 years ago

Features

Function After submission of the website contact form it will search the res.partner records based on email address and name entered in the form and update the record if one has been found.

Contacts - Configuration - Contact Search There are two fields available to define the value to search for and the models to search in. Results will be displayed according to record id and record name.

pedrobaeza commented 6 years ago

HI, thanks for your first submission to OCA!

I see several problems with this PR:

yvaucher commented 6 years ago

@ITISAG-OCA Hello, I believe this is one of your first contributions on the OCA, so welcome! (correct me if I'm wrong)

First of all, please acknowledge that we prefer individual github account to push changes. It allows to grant access rights to a better definition and also to know to who we are talking. It is always easier to match someone you cross at a code sprint and recognize what was his involvement as an individual in the community. The OCA also ask individuals to sign a CLA to contribute.

Here are the Contributiing OCA Guidlines that I suggest you to read.

Otherwise, let me ask you what is the difference with this module compared to the privacy module of version 10.0?

ITISAG-OCA commented 6 years ago

Hello Mr. Vaucher,

yes this was intended as our first contribution to the OCA. Regarding the account you are right and we still need to set up individual users for better recognition. Upon reading the Guidelines again I'm working on a revised version of the module to reupload. As for the mentioned module privacy, i was not aware of it's existence. I did find it in the version 10 branch of the data-protection repository. As far as i can tell there is not much functionality in it as of today. Our module that we wanted to merge with the Odoo 11 data-protection repository is also a work in progress. The functionality is as follows: 

* The website contact form is extended by additional fields, so the customer can choose in what way he wants to be contacted in the future. The entered name and email address is matched against the res.partner model and if a match is found the choice made in the contact form is entered in the corresponding fields in res.partner. 
* There is a search functionality in the Contacts App that lets you search any Model for information. 
* A report regarding the GDPR information request is also available from the Contact view.

As i have said it is a work in progress and will have to be developed further. Thank you for taking the time to respond to our request.

regards

Sven Hartmann

IT IS AG

Tel.: [ callto:+49%208703%209069%200 | +49 8703 9069 0 ]

Fax: [ callto:+49%208703%209069%20200 | +49 8703 9069 200 ]

Landshut – Deutschland

[ http://www.itis.de/ | www.itis.de ]

[ mailto:kontakt@itis.de | kontakt@itis.de ]

Vorstandsvorsitzender: Dipl.-Ing. Joerg Lorenz, Aufsichtsratsvorsitzende: Anke Lorenz Handelsregister: Landshut HRB 5072 USt.-ID.-Nummer: DE 812896466

Dieses E-Mail ist vertraulich. Wenn Sie nicht der rechtmaessige Empfaenger sind, duerfen Sie den Inhalt weder kopieren, verbreiten oder benutzen.

Sollten Sie dieses E-Mail versehentlich erhalten haben, senden Sie es bitte an uns zurueck und loeschen es anschliessend.

From: "Yannick Vaucher" notifications@github.com To: "OCA/data-protection" data-protection@noreply.github.com Cc: "IT IS AG" oca@itis.de, "Mention" mention@noreply.github.com Sent: Friday, June 22, 2018 6:31:48 PM Subject: Re: [OCA/data-protection] GDPR Module for OCA V11 (#10)

[ https://github.com/ITISAG-OCA | @ITISAG-OCA ] Hello, I believe this is one of your first contributions on the OCA, so welcome! (correct me if I'm wrong)

First of all, please acknowledge that we prefer individual github account to push changes. It allows to grant access rights to a better definition and also to know to who we are talking. It is always easier to match someone you cross at a code sprint and recognize what was his involvement as an individual in the community. The OCA also ask individuals to sign a CLA to contribute.

Here are the Contributiing [ https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md | OCA Guidlines ] that I suggest you to read.

Otherwise, let me ask you what is the difference with this module compared to the privacy module of version 10.0?

— You are receiving this because you were mentioned. Reply to this email directly, [ https://github.com/OCA/data-protection/pull/10#issuecomment-399502654 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/Amnv_C8y6pmOMBj9U-MPBnXa0P4V7C98ks5t_Rv0gaJpZM4U0Elc | mute the thread ] .

ITISAG-OCA commented 6 years ago

Hello Mr. Baeza,

thank you for responding to our request. First of all you are correct and after reading the Guidelines i am working on a revised Version of the Module. It is also a work in progress. Regarding the functionality: 

* The website contact form is extended by additional fields, so the customer can choose in what way he wants to be contacted in the future. The entered name and email address is matched against the res.partner model and if a match is found the choice made in the contact form is entered in the corresponding fields in res.partner. 
* There is a search functionality in the Contacts App that lets you search any Model for information. 
* A report regarding the GDPR information request is also available from the Contact view.

The website functionalities are specifically for the General Data Protection Regulation, so the customer can request information via the website or maek a choice on how he wants to be contacted. For that reason i thought the right repository would be OCA/data-protection. I'm of course open to other suggestions and as you have said we are or would like to be new contributors to the OCA. I will remove the module in it's current state from our fork and reupload it when i have done a rework.

Best regards Sven Hartmann

IT IS AG

Tel.: [ callto:+49%208703%209069%200 | +49 8703 9069 0 ]

Fax: [ callto:+49%208703%209069%20200 | +49 8703 9069 200 ]

Landshut – Deutschland

[ http://www.itis.de/ | www.itis.de ]

[ mailto:kontakt@itis.de | kontakt@itis.de ]

Vorstandsvorsitzender: Dipl.-Ing. Joerg Lorenz, Aufsichtsratsvorsitzende: Anke Lorenz Handelsregister: Landshut HRB 5072 USt.-ID.-Nummer: DE 812896466

Dieses E-Mail ist vertraulich. Wenn Sie nicht der rechtmaessige Empfaenger sind, duerfen Sie den Inhalt weder kopieren, verbreiten oder benutzen.

Sollten Sie dieses E-Mail versehentlich erhalten haben, senden Sie es bitte an uns zurueck und loeschen es anschliessend.

From: "Pedro M. Baeza" notifications@github.com To: "OCA/data-protection" data-protection@noreply.github.com Cc: "IT IS AG" oca@itis.de, "Author" author@noreply.github.com Sent: Friday, June 22, 2018 6:31:15 PM Subject: Re: [OCA/data-protection] GDPR Module for OCA V11 (#10)

HI, thanks for your first submission to OCA!

I see several problems with this PR: 

* The module name includes the company name, which is forbidden here in OCA. 
* It includes a lot of several things inside the same module. We tend to put each of the features in separate modules for better granularity. For example, if you don't use mass_mailing or website, why do you have to install them for having the possibility of the report creation? You can even put one base module, and extensions to that module according possible areas. 
* There are some things that can fit better in other OCA repositories, like OCA/website, OCA/social. 
* The module has to comply with minimum OCA guidelines, that are in [ https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md | https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md ] . Travis red flag indicates that this doesn't comply in something.

— You are receiving this because you authored the thread. Reply to this email directly, [ https://github.com/OCA/data-protection/pull/10#issuecomment-399502476 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/Amnv_JZCF-_Pt-TQYdQudhpiu4M0M0Qgks5t_RvTgaJpZM4U0Elc | mute the thread ] .

ITISAG-OCA commented 6 years ago

Hello Yannick, thanks for pointing this out. a couple of thoughts about your comment.

We are contributing as an organisation and will retain copyrights about our work. Thus we always will contribute as IT IS AG, and this is perfectly fine with Joel and Maxime. But we are are happy to eliminate the name in the naming schema of the module, of cause.

For the details, our collegues will get into touch with you. Please help them understand how we can contribute the best way possible.

Many thanks and have a great day.

Joe IT IS AG

Von: "Yannick Vaucher" notifications@github.com An: "OCA/data-protection" data-protection@noreply.github.com CC: "IT IS AG" oca@itis.de, "Mention" mention@noreply.github.com Gesendet: Freitag, 22. Juni 2018 18:31:48 Betreff: Re: [OCA/data-protection] GDPR Module for OCA V11 (#10)

[ https://github.com/ITISAG-OCA | @ITISAG-OCA ] Hello, I believe this is one of your first contributions on the OCA, so welcome! (correct me if I'm wrong)

First of all, please acknowledge that we prefer individual github account to push changes. It allows to grant access rights to a better definition and also to know to who we are talking. It is always easier to match someone you cross at a code sprint and recognize what was his involvement as an individual in the community. The OCA also ask individuals to sign a CLA to contribute.

Here are the Contributiing [ https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md | OCA Guidlines ] that I suggest you to read.

Otherwise, let me ask you what is the difference with this module compared to the privacy module of version 10.0?

— You are receiving this because you were mentioned. Reply to this email directly, [ https://github.com/OCA/data-protection/pull/10#issuecomment-399502654 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/Amnv_C8y6pmOMBj9U-MPBnXa0P4V7C98ks5t_Rv0gaJpZM4U0Elc | mute the thread ] .

pedrobaeza commented 6 years ago

@ITISAG-OCA what I'm requesting is to split modules by dependencies for having each feature without the need of installing everything. I can be able to retrieve partner information without the need of installing website part.

ITISAG-OCA commented 6 years ago

Hello Mr. Baeza,

i got your point regarding the dependencies. For one the dependency to mass_mailing has been removed. However the website dependency is necessary because the website contact form is extended to allow customers to make a choice about the way they want to be contacted in the future. To be able to make this choice the email address entered in the contact form has to be verified by a link that is sent to that address.

The second feature is the search view. It is located in Contacts -> Configuration after the User has checked "Data Protection Officers" in Users -> Technical Settings. Odoo models can be searched for matches by entering a search string in the form. Disclosing to customers what information is stored about them is part of the new regulation. We thought this feature might make it easier to gather that information.

As such those two functionalities are specifically for the website module of Odoo. Do you still think they should be split up?

Regards

Sven Hartmann IT IS AG

From: "Pedro M. Baeza" notifications@github.com To: "OCA/data-protection" data-protection@noreply.github.com Cc: "IT IS AG" oca@itis.de, "Mention" mention@noreply.github.com Sent: Thursday, June 28, 2018 6:59:47 PM Subject: Re: [OCA/data-protection] GDPR Module for OCA V11 (#10)

[ https://github.com/ITISAG-OCA | @ITISAG-OCA ] what I'm requesting is to split modules by dependencies for having each feature without the need of installing everything. I can be able to retrieve partner information without the need of installing website part.

— You are receiving this because you were mentioned. Reply to this email directly, [ https://github.com/OCA/data-protection/pull/10#issuecomment-401104102 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/Amnv_PIDmuANEhXYfHWkdIei_enTGnDkks5uBQuDgaJpZM4U0Elc | mute the thread ] .

pedrobaeza commented 6 years ago

I'm afraid you are still not understanding me. What I request is to split current module into several smaller ones, one per feature dependency (and maybe a general parent module for all of them with the common ground).

ITISAG-OCA commented 6 years ago

We can do that, that is not a problem.

Regards

Sven Hartmann IT IS AG

From: "Pedro M. Baeza" notifications@github.com To: "OCA/data-protection" data-protection@noreply.github.com Cc: "oca" oca@itis.de, "Mention" mention@noreply.github.com Sent: Friday, June 29, 2018 6:05:28 PM Subject: Re: [OCA/data-protection] GDPR Module for OCA V11 (#10)

I'm afraid you are still not understanding me. What I request is to split current module into several smaller ones, one per feature dependency (and maybe a general parent module for all of them with the common ground).

— You are receiving this because you were mentioned. Reply to this email directly, [ https://github.com/OCA/data-protection/pull/10#issuecomment-401400086 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/Amnv_FMRh4RE2tefQbsarThVksBsz8TJks5uBlBIgaJpZM4U0Elc | mute the thread ] .

ITISAG-OCA commented 6 years ago

Hello Mr. Baeza,

Since our last email exchange we split the module up into two modules. One per feature as requested. Also since our modules are intended for and committed to the Version 11 branch of the repository data-protection i noticed that the automated build job is still using Odoo 10 for the 11 branch. If you could give any feedback it would be very welcome. Thank you.

Best regards Sven Hartmann

From: "Pedro M. Baeza" notifications@github.com To: "OCA/data-protection" data-protection@noreply.github.com Cc: "oca" oca@itis.de, "Mention" mention@noreply.github.com Sent: Friday, June 29, 2018 6:05:28 PM Subject: Re: [OCA/data-protection] GDPR Module for OCA V11 (#10)

I'm afraid you are still not understanding me. What I request is to split current module into several smaller ones, one per feature dependency (and maybe a general parent module for all of them with the common ground).

— You are receiving this because you were mentioned. Reply to this email directly, [ https://github.com/OCA/data-protection/pull/10#issuecomment-401400086 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/Amnv_FMRh4RE2tefQbsarThVksBsz8TJks5uBlBIgaJpZM4U0Elc | mute the thread ] .

ITISAG-OCA commented 6 years ago

Hi Pedro: I wanted to ask about the contribution we have proposed. Below is th latest thread, and we are not aware of news since two weeks. Please let us know what is helding us up and if we can be of any help?

Thanks, Joe

Von: support@itis.de An: "OCA" reply@reply.github.com CC: "projectmanagement" projectmanagement@itis.de Gesendet: Freitag, 13. Juli 2018 18:27:06 Betreff: Re: [OCA/data-protection] GDPR Module for OCA V11

Hello Mr. Baeza,

Since our last email exchange we split the module up into two modules. One per feature as requested. Also since our modules are intended for and committed to the Version 11 branch of the repository data-protection i noticed that the automated build job is still using Odoo 10 for the 11 branch. If you could give any feedback it would be very welcome. Thank you.

Best regards Sven Hartmann

From: "Pedro M. Baeza" notifications@github.com To: "OCA/data-protection" data-protection@noreply.github.com Cc: "oca" oca@itis.de, "Mention" mention@noreply.github.com Sent: Friday, June 29, 2018 6:05:28 PM Subject: Re: [OCA/data-protection] GDPR Module for OCA V11 (#10)

I'm afraid you are still not understanding me. What I request is to split current module into several smaller ones, one per feature dependency (and maybe a general parent module for all of them with the common ground).

— You are receiving this because you were mentioned. Reply to this email directly, [ https://github.com/OCA/data-protection/pull/10#issuecomment-401400086 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/Amnv_FMRh4RE2tefQbsarThVksBsz8TJks5uBlBIgaJpZM4U0Elc | mute the thread ] .

pedrobaeza commented 6 years ago

I have been on holidays. I will try to do my best reviewing it ASAP, but take into account also that there's no obligation for it.

ITISAG-OCA commented 6 years ago

Dear Pedro: No worries, just wanted to be helpful and I think that some people are keen for it. If you have suggestion, please be my guest.

Thanks, Joe

Von: "Pedro M. Baeza" notifications@github.com An: "OCA/data-protection" data-protection@noreply.github.com CC: "IT IS AG" oca@itis.de, "Mention" mention@noreply.github.com Gesendet: Montag, 30. Juli 2018 13:52:25 Betreff: Re: [OCA/data-protection] GDPR Module for OCA V11 (#10)

I have been on holidays. I will try to do my best reviewing it ASAP, but take into account also that there's no obligation for it.

— You are receiving this because you were mentioned. Reply to this email directly, [ https://github.com/OCA/data-protection/pull/10#issuecomment-408837522 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/Amnv_AirjQPG6AqOcFXZME26a-id_bjUks5uLvN5gaJpZM4U0Elc | mute the thread ] .

ITISAG-OCA commented 6 years ago

Dear Mr. Baeza,

thank you very much for your detailed review. The change requests have been added to the module in a new commit. Unfortunately I'm not sure how to move the module contact_search_form into a new PR or remove the other module website_contact_extend from the current PR #10. I have also commented your change requests below.

The overall feeling of this module is that we already have tools in OCA for making this kind of contact search (look web_advanced_search module in OCA/web), but maybe I'm wrong. Can you tell me if not what is >>>the advantages of this? Maybe simplicity?

As i understand it web_advanced_search offers an extended filter functionality in the search bar but is limited to the model and relational fields it is used in. Whereas our search function (contact_search_form) is intended to provide a quick way to search for a specified string in all available models at the same time (models can be added / removed from the search query). By doing this the user does not have to navigate through every app he/she wants to look for information in. It is kept very simple and easy to use.

Best regards

ITISAG-OCA commented 6 years ago

Dear Mr. Baeza,

could i kindly remind you of my reply to your review? I implemented the changes you requested. Is there something else that hinders the acceptance of the module?

thank you Best regards

Sven Hartmann

pedrobaeza commented 6 years ago

@ITISAG-OCA I will ask other colleague for helping me in reviewing this. I would ask you to not reply from mail or at least remove all the quoted text that you don't want to highlight for avoiding here spamming the PR with a lot of duplicated text + sign and so on.

yajo commented 6 years ago

Hi there!

1st of all thanks and welcome! I'm having a look at the PR and I have to admit it's pretty difficult to understand what's the exact purpose of each of the addons you're publishing.

AFAICS from the code and your comments, it seems you are publishing an addon that was previously a custom module somewhere else. TBH, when I first started contributing at @OCA, I had a similar use case, but when contributing here, you have to "think bigger". Let me expose some doubts that come to my mind when reading this.

For instance, this search enhacement... I feel it would be much easier if you explain before what's the thing that you're missing from Odoo search. For instance, it seems to me that you're trying to search some string among all the text fields of all the records of all the specified models. Am I right? If so, then the next question is: how does this relate to personal data protection? Why only the DPO is able to do such seach? What if I want to do that global search among my own email messages, or among sales orders, which are sold to companies (not persons), where I already have permissions to search? What if I only use Odoo to manage blog posts and mailing lists? Then there's the performance, because giving an end user the possibility to enable searches among all the database is for sure a big hole for performance bottlenecks, don't you think?

I think that the relation is that you want to use that information to be able to print a report with all of a customer's information, but then that's not the way to do it, because the fact that a text contains "Steve" doesn't mean it's related to "Steve Urkel"... there can be many Steves out there, some of which can be related to a separate company, and also you could rename it to "Stephen" at some point. You need relations for that, and that's why we have a relational database that uses IDs instead of plain strings to form relations.

Then we go to the contact form stuff... As you can see by the module name (website_CRM), it's a sales-related thing. It creates leads, which should get converted to sales by an intelligent salesman. It's not meant to update user preferences, and even if a user would want to use it for that, the user would write a message such as "hey! I want you to stop emailing me. Phone me.", which would get then forwarded from the salesman to the DPO, which should handle that case properly.

To update user preferences, there's website_portal, which already lets a user update its address, etc., and is officially supported, so you could reuse some of website_portal and add to it the possibility to update contact method preferences.

BTW, Odoo already has a field to choose how to receive notification, which allows you to choose you want none. Then, if a user sees that the contact doesn't get notifications by email, and it has a phone, he can guess by himself that this person wants to be contacted only by phone. Do we really need an extra field for that? And if we do need it... What relation does that have with GDPR? Can't company accounts express such preferences too? Do we have a way to guarantee that preference is going to be respected?

So, when we sort out these design questions, then there's another question: Is there another existing addon that solves the problem? If so, then OCA will not accept yours, because it makes no sense to have 2 addons doing the same thing, right? Some examples:

So I prefer not to enter code review before sorting out the design first.

Maybe you can record a screencast of your addons showing what are they actually doing, so we can suggest you more viable alternatives, or better places where to publish your contributions (maybe a different OCA repo, if this is not GDPR-related).

Kind regards.

ITISAG-OCA commented 6 years ago

Hi Jairo, hello Pedro:

these questions you are raising has been well thought and well balanced already. The module is NOT coming from a customer module, but from a concept we have done together with Daniel Reis, one of the OCA board members and us, upon numerous requests from all sorts of customers. Please have a look into the concept attached here: GDPR_Work_Breakdown_Structure-11MAY2018.odt

Please also have a look into the rules and regulations of GDPR here: CELEX_32016R0679_EN_TXT.pdf

and the German directive derived from this here: OH-Datenschutz-im-Verein-nach-der-DSGVO.pdf I am certain that you will be finding a Spanish counterpart also- Your will be surprised to see the amount of formalism about this.

Just for your information about how other market followers handle this, see this topic, I have added this document here: Dynamics-NAV-GDPR-Whitepaper.pdf

For you convenience, I have downloaded and attached everything in here.

In particular on the reusage of other modules: Yes, we aim to reuse what we find on the OCA. Here we have decided not to reuse the OCA search, because of the way the customer needs to configure his search by law . This is not optional. And yes: we could use the website builder, but this doesn't relate to the particular usage scenario we have here, which is invoking documents to be sent upon the questioners request and a markup in odoo about the ways of communication that the owner of the data decided to rule.

on your blue text areas: These are not linked, so I cannot look them up all. But just try the privacy module yourself and tell me how this is usable for a GDPR

I am happy to go through our topics and questions from a design standpoint of view, but I would prefer a oral communication since it is much quicker and more reactive.

So if you could let me know a number to call and a date that fits, I am happy to address your concerns.

There is one request I would have: Please let us make this walk through throughout this week, we need to get ready with this module and bring it live.

Best regards, Joerg Lorenz IT IS AG

----- Ursprüngliche Mail -----

Von: "Jairo Llopis" notifications@github.com An: "OCA/data-protection" data-protection@noreply.github.com CC: "IT IS AG" oca@itis.de, "Mention" mention@noreply.github.com Gesendet: Montag, 15. Oktober 2018 11:41:37 Betreff: Re: [OCA/data-protection] GDPR Module for OCA V11 (#10)

Hi there! 1st of all thanks and welcome! I'm having a look at the PR and I have to admit it's pretty difficult to understand what's the exact purpose of each of the addons you're publishing. AFAICS from the code and your comments, it seems you are publishing an addon that was previously a custom module somewhere else. TBH, when I first started contributing at @OCA , I had a similar use case, but when contributing here, you have to "think bigger". Let me expose some doubts that come to my mind when reading this. For instance, this search enhacement... I feel it would be much easier if you explain before what's the thing that you're missing from Odoo search. For instance, it seems to me that you're trying to search some string among all the text fields of all the records of all the specified models . Am I right? If so, then the next question is: how does this relate to personal data protection? Why only the DPO is able to do such seach? What if I want to do that global search among my own email messages, or among sales orders, which are sold to companies (not persons), where I already have permissions to search? What if I only use Odoo to manage blog posts and mailing lists? Then there's the performance, because giving an end user the possibility to enable searches among all the database is for sure a big hole for performance bottlenecks, don't you think? I think that the relation is that you want to use that information to be able to print a report with all of a customer's information, but then that's not the way to do it, because the fact that a text contains "Steve" doesn't mean it's related to "Steve Urkel"... there can be many Steves out there, some of which can be related to a separate company, and also you could rename it to "Stephen" at some point. You need relations for that, and that's why we have a relational database that uses IDs instead of plain strings to form relations. Then we go to the contact form stuff... As you can see by the module name (website_CRM), it's a sales-related thing. It creates leads, which should get converted to sales by an intelligent salesman. It's not meant to update user preferences, and even if a user would want to use it for that, the user would write a message such as "hey! I want you to stop emailing me. Phone me.", which would get then forwarded from the salesman to the DPO, which should handle that case properly. To update user preferences, there's website_portal , which already lets a user update its address, etc., and is officially supported, so you could reuse some of website_portal and add to it the possibility to update contact method preferences. BTW, Odoo already has a field to choose how to receive notification, which allows you to choose you want none. Then, if a user sees that the contact doesn't get notifications by email, and it has a phone, he can guess by himself that this person wants to be contacted only by phone. Do we really need an extra field for that? And if we do need it... What relation does that have with GDPR? Can't company accounts express such preferences too? Do we have a way to guarantee that preference is going to be respected? So, when we sort out these design questions, then there's another question: Is there another existing addon that solves the problem? If so, then OCA will not accept yours, because it makes no sense to have 2 addons doing the same thing, right? Some examples: 

* The privacy addon defines data protection user and manager groups . You don't need to define new equal groups here, just depend on that. 
* The website_form_builder addon lets you add custom fields to website forms , such as the contact form that website_crm creates. Can you use that to add the fields you need in your customer database instead of having to create a new addon? 
* web_advanced_search lets you have improved, optimized, secure and relational advanced searches . The user can make such search and then save it as a custom filter. Do we really need this other dangerous addon? 
* privacy_partner_report exports a report with all data related to a res.partner . Do we really need a different addon that makes the same?

So I prefer not to enter code review before sorting out the design first. Maybe you can record a screencast of your addons showing what are they actually doing, so we can suggest you more viable alternatives, or better places where to publish your contributions (maybe a different OCA repo, if this is not GDPR-related). Kind regards. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub , or mute the thread .

pedrobaeza commented 6 years ago

Joerg, there's no need of including us in copy in the mail. We receive the same notification from GitHub.

Thanks for your comments. We are not going to be more picky about the features for not discouraging you on your contribution. Let's focus now on the technical part. There are several minimum fails and warnings on CIs:

flake8:

contact_search_form/__manifest__.py:10:80: E501 line too long (98 > 79 characters)
contact_search_form/models/contact_search.py:43:5: E124 closing bracket does not match visual indentation
contact_search_form/models/contact_search.py:47:5: E124 closing bracket does not match visual indentation

pylint

Using config file /home/travis/maintainer-quality-tools/travis/cfg/travis_run_pylint.cfg
************* Module contact_search_form
contact_search_form/__init__.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang_(Unix) ). If you don't needs a execution permission then remove it with: chmod -x __init__.py
contact_search_form/__init__.py:1: [C7902(missing-readme), ] Missing ./README.rst file. Template here: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst
contact_search_form/security/gdpr_security.xml:1: [W7908(missing-newline-extrafiles), ]  Missing newline
************* Module contact_search_form.__manifest__
contact_search_form/__manifest__.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use `# coding: utf-8` or `# -*- coding: utf-8 -*-`
contact_search_form/__manifest__.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang_(Unix) ). If you don't needs a execution permission then remove it with: chmod -x __manifest__.py
************* Module contact_search_form.models.__init__
contact_search_form/models/__init__.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang_(Unix) ). If you don't needs a execution permission then remove it with: chmod -x __init__.py
************* Module contact_search_form.models.contact_search
contact_search_form/models/contact_search.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use `# coding: utf-8` or `# -*- coding: utf-8 -*-`
contact_search_form/models/contact_search.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang_(Unix) ). If you don't needs a execution permission then remove it with: chmod -x contact_search.py
contact_search_form/models/contact_search.py:28: [W8104(api-one-deprecated), SearchLine._compute_record_name] api.one deprecated
************* Module website_contact_extend
website_contact_extend/__init__.py:1: [C7902(missing-readme), ] Missing ./README.rst file. Template here: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst
website_contact_extend/data/email_templates.xml:1: [W7908(missing-newline-extrafiles), ]  Missing newline
website_contact_extend/views/contact_report.xml:1: [W7908(missing-newline-extrafiles), ]  Missing newline
website_contact_extend/views/res_partner.xml:1: [W7908(missing-newline-extrafiles), ]  Missing newline
website_contact_extend/views/website_contact.xml:1: [W7908(missing-newline-extrafiles), ]  Missing newline
website_contact_extend/readme/USAGE.rst:1: [W7908(missing-newline-extrafiles), ]  Missing newline
************* Module website_contact_extend.__manifest__
website_contact_extend/__manifest__.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use `# coding: utf-8` or `# -*- coding: utf-8 -*-`
************* Module website_contact_extend.controllers.myfilter
website_contact_extend/controllers/myfilter.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use `# coding: utf-8` or `# -*- coding: utf-8 -*-`
************* Module website_contact_extend.models.res_partner
website_contact_extend/models/res_partner.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use `# coding: utf-8` or `# -*- coding: utf-8 -*-`
-----------------------------------
Using config file /home/travis/maintainer-quality-tools/travis/cfg/travis_run_pylint_pr.cfg
************* Module contact_search_form
contact_search_form/__init__.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang_(Unix) ). If you don't needs a execution permission then remove it with: chmod -x __init__.py
contact_search_form/__init__.py:1: [C7902(missing-readme), ] Missing ./README.rst file. Template here: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst
contact_search_form/security/gdpr_security.xml:1: [W7908(missing-newline-extrafiles), ]  Missing newline
************* Module contact_search_form.__manifest__
contact_search_form/__manifest__.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use `# coding: utf-8` or `# -*- coding: utf-8 -*-`
contact_search_form/__manifest__.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang_(Unix) ). If you don't needs a execution permission then remove it with: chmod -x __manifest__.py
contact_search_form/__manifest__.py:7: [C8106(manifest-version-format), ] Wrong Version Format "11.0.1.0.0" in manifest file. Regex to match: "(10\.0)\.\d+\.\d+\.\d+$"
************* Module contact_search_form.models.__init__
contact_search_form/models/__init__.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang_(Unix) ). If you don't needs a execution permission then remove it with: chmod -x __init__.py
************* Module contact_search_form.models.contact_search
contact_search_form/models/contact_search.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use `# coding: utf-8` or `# -*- coding: utf-8 -*-`
contact_search_form/models/contact_search.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang_(Unix) ). If you don't needs a execution permission then remove it with: chmod -x contact_search.py
contact_search_form/models/contact_search.py:28: [W8104(api-one-deprecated), SearchLine._compute_record_name] api.one deprecated
************* Module website_contact_extend
website_contact_extend/__init__.py:1: [C7902(missing-readme), ] Missing ./README.rst file. Template here: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst
website_contact_extend/data/email_templates.xml:1: [W7908(missing-newline-extrafiles), ]  Missing newline
website_contact_extend/views/contact_report.xml:1: [W7908(missing-newline-extrafiles), ]  Missing newline
website_contact_extend/views/res_partner.xml:1: [W7908(missing-newline-extrafiles), ]  Missing newline
website_contact_extend/views/website_contact.xml:1: [W7908(missing-newline-extrafiles), ]  Missing newline
website_contact_extend/readme/USAGE.rst:1: [W7908(missing-newline-extrafiles), ]  Missing newline
************* Module website_contact_extend.__manifest__
website_contact_extend/__manifest__.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use `# coding: utf-8` or `# -*- coding: utf-8 -*-`
website_contact_extend/__manifest__.py:7: [C8106(manifest-version-format), ] Wrong Version Format "11.0.1.0.0" in manifest file. Regex to match: "(10\.0)\.\d+\.\d+\.\d+$"
************* Module website_contact_extend.controllers.myfilter
website_contact_extend/controllers/myfilter.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use `# coding: utf-8` or `# -*- coding: utf-8 -*-`
************* Module website_contact_extend.models.res_partner
website_contact_extend/models/res_partner.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use `# coding: utf-8` or `# -*- coding: utf-8 -*-`

And runbot

2018-10-08 14:15:08,841 186 WARNING openerp_test odoo.addons.base.module.module: module contact_search_form: description is empty !
2018-10-08 14:15:09,600 186 WARNING openerp_test odoo.addons.base.module.module: module website_contact_extend: description is empty !

With that fixed, let's move forward and look for other contributions to rise!

ITISAG-OCA commented 6 years ago

Thanks, Pedro: Just going to forward to team , and will provide you with a quick answer / modifications according to your findings.

----- Ursprüngliche Mail -----

Von: "Pedro M. Baeza" notifications@github.com An: "OCA/data-protection" data-protection@noreply.github.com CC: "IT IS AG" oca@itis.de, "Mention" mention@noreply.github.com Gesendet: Montag, 15. Oktober 2018 17:00:00 Betreff: Re: [OCA/data-protection] GDPR Module for OCA V11 (#10)

Joerg, there's no need of including us in copy in the mail. We receive the same notification from GitHub. Thanks for your comments. We are not going to be more picky about the features for not discouraging you on your contribution. Let's focus now on the technical part. There are several minimum fails and warnings on CIs: flake8: contact_search_form/manifest.py:10:80: E501 line too long (98 > 79 characters) contact_search_form/models/contact_search.py:43:5: E124 closing bracket does not match visual indentation contact_search_form/models/contact_search.py:47:5: E124 closing bracket does not match visual indentation pylint Using config file /home/travis/maintainer-quality-tools/travis/cfg/travis_run_pylint.cfg Module contact_search_form contact_searchform/init.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang(Unix) ). If you don't needs a execution permission then remove it with: chmod -x init.py contact_search_form/init.py:1: [C7902(missing-readme), ] Missing ./README.rst file. Template here: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst contact_search_form/security/gdpr_security.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline Module contact_search_form.manifest contact_search_form/manifest.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*- contact_searchform/manifest.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang(Unix) ). If you don't needs a execution permission then remove it with: chmod -x manifest.py Module contact_search_form.models.init contact_searchform/models/init.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang(Unix) ). If you don't needs a execution permission then remove it with: chmod -x init.py Module contact_search_form.models.contact_search contact_search_form/models/contact_search.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*- contact_search_form/models/contactsearch.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang(Unix) ). If you don't needs a execution permission then remove it with: chmod -x contact_search.py contact_search_form/models/contact_search.py:28: [W8104(api-one-deprecated), SearchLine._compute_record_name] api.one deprecated Module website_contact_extend website_contact_extend/init.py:1: [C7902(missing-readme), ] Missing ./README.rst file. Template here: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst website_contact_extend/data/email_templates.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline website_contact_extend/views/contact_report.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline website_contact_extend/views/res_partner.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline website_contact_extend/views/website_contact.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline website_contact_extend/readme/USAGE.rst:1: [W7908(missing-newline-extrafiles), ] Missing newline Module website_contact_extend.manifest website_contact_extend/manifest.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*- Module website_contact_extend.controllers.myfilter website_contact_extend/controllers/myfilter.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or `# -- coding: utf-8 --` Module website_contact_extend.models.res_partner website_contact_extend/models/res_partner.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*-

Using config file /home/travis/maintainer-quality-tools/travis/cfg/travis_run_pylint_pr.cfg Module contact_search_form contact_searchform/init.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang(Unix) ). If you don't needs a execution permission then remove it with: chmod -x init.py contact_search_form/init.py:1: [C7902(missing-readme), ] Missing ./README.rst file. Template here: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst contact_search_form/security/gdpr_security.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline Module contact_search_form.manifest contact_search_form/manifest.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*- contact_searchform/manifest.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang(Unix) ). If you don't needs a execution permission then remove it with: chmod -x manifest.py contact_search_form/manifest.py:7: [C8106(manifest-version-format), ] Wrong Version Format "11.0.1.0.0" in manifest file. Regex to match: "(10.0).\d+.\d+.\d+$" Module contact_search_form.models.init contact_searchform/models/init.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang(Unix) ). If you don't needs a execution permission then remove it with: chmod -x init.py Module contact_search_form.models.contact_search contact_search_form/models/contact_search.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*- contact_search_form/models/contactsearch.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang(Unix) ). If you don't needs a execution permission then remove it with: chmod -x contact_search.py contact_search_form/models/contact_search.py:28: [W8104(api-one-deprecated), SearchLine._compute_record_name] api.one deprecated Module website_contact_extend website_contact_extend/init.py:1: [C7902(missing-readme), ] Missing ./README.rst file. Template here: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst website_contact_extend/data/email_templates.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline website_contact_extend/views/contact_report.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline website_contact_extend/views/res_partner.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline website_contact_extend/views/website_contact.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline website_contact_extend/readme/USAGE.rst:1: [W7908(missing-newline-extrafiles), ] Missing newline Module website_contact_extend.manifest website_contact_extend/manifest.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*- website_contact_extend/manifest.py:7: [C8106(manifest-version-format), ] Wrong Version Format "11.0.1.0.0" in manifest file. Regex to match: "(10.0).\d+.\d+.\d+$" Module website_contact_extend.controllers.myfilter website_contact_extend/controllers/myfilter.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or `# -- coding: utf-8 --` Module website_contact_extend.models.res_partner website_contact_extend/models/res_partner.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*- And runbot 2018-10-08 14:15:08,841 186 WARNING openerp_test odoo.addons.base.module.module: module contact_search_form: description is empty ! 2018-10-08 14:15:09,600 186 WARNING openerp_test odoo.addons.base.module.module: module website_contact_extend: description is empty ! With that fixed, let's move forward and look for other contributions to rise! — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub , or mute the thread .

ITISAG-OCA commented 6 years ago

Dear Mr. Baeza,

we have updated the modules based on the list below. However i have doubts concerning the following two issues as both are indicating that the tests running on OCA/data-protection branch 11.0 are executed in an Odoo 10 environment: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*- [C8106(manifest-version-format), ] Wrong Version Format "11.0.1.0.0" in manifest file. Regex to match: "(10.0).\d+.\d+.\d+$"

The modules we provided are intended for the branch 11.0.

Best regards

Sven Hartmann IT IS AG

From: "Pedro M. Baeza" notifications@github.com To: "OCA/data-protection" data-protection@noreply.github.com Cc: "oca" oca@itis.de, "Mention" mention@noreply.github.com Sent: Monday, October 15, 2018 5:00:00 PM Subject: Re: [OCA/data-protection] GDPR Module for OCA V11 (#10)

Joerg, there's no need of including us in copy in the mail. We receive the same notification from GitHub.

Thanks for your comments. We are not going to be more picky about the features for not discouraging you on your contribution. Let's focus now on the technical part. There are several minimum fails and warnings on CIs:

flake8: contact_search_form/manifest.py:10:80: E501 line too long (98 > 79 characters) contact_search_form/models/contact_search.py:43:5: E124 closing bracket does not match visual indentation contact_search_form/models/contact_search.py:47:5: E124 closing bracket does not match visual indentation

pylint Using config file /home/travis/maintainer-quality-tools/travis/cfg/travis_run_pylint.cfg Module contact_search_form contact_searchform/init.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang(Unix) ). If you don't needs a execution permission then remove it with: chmod -x init.py contact_search_form/init.py:1: [C7902(missing-readme), ] Missing ./README.rst file. Template here: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst contact_search_form/security/gdpr_security.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline Module contact_search_form.manifest contact_search_form/manifest.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*- contact_searchform/manifest.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang(Unix) ). If you don't needs a execution permission then remove it with: chmod -x manifest.py Module contact_search_form.models.init contact_searchform/models/init.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang(Unix) ). If you don't needs a execution permission then remove it with: chmod -x init.py Module contact_search_form.models.contact_search contact_search_form/models/contact_search.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*- contact_search_form/models/contactsearch.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang(Unix) ). If you don't needs a execution permission then remove it with: chmod -x contact_search.py contact_search_form/models/contact_search.py:28: [W8104(api-one-deprecated), SearchLine._compute_record_name] api.one deprecated Module website_contact_extend website_contact_extend/init.py:1: [C7902(missing-readme), ] Missing ./README.rst file. Template here: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst website_contact_extend/data/email_templates.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline website_contact_extend/views/contact_report.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline website_contact_extend/views/res_partner.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline website_contact_extend/views/website_contact.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline website_contact_extend/readme/USAGE.rst:1: [W7908(missing-newline-extrafiles), ] Missing newline Module website_contact_extend.manifest website_contact_extend/manifest.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*- Module website_contact_extend.controllers.myfilter website_contact_extend/controllers/myfilter.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or `# -- coding: utf-8 --` Module website_contact_extend.models.res_partner website_contact_extend/models/res_partner.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*-

Using config file /home/travis/maintainer-quality-tools/travis/cfg/travis_run_pylint_pr.cfg Module contact_search_form contact_searchform/init.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang(Unix) ). If you don't needs a execution permission then remove it with: chmod -x init.py contact_search_form/init.py:1: [C7902(missing-readme), ] Missing ./README.rst file. Template here: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst contact_search_form/security/gdpr_security.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline Module contact_search_form.manifest contact_search_form/manifest.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*- contact_searchform/manifest.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang(Unix) ). If you don't needs a execution permission then remove it with: chmod -x manifest.py contact_search_form/manifest.py:7: [C8106(manifest-version-format), ] Wrong Version Format "11.0.1.0.0" in manifest file. Regex to match: "(10.0).\d+.\d+.\d+$" Module contact_search_form.models.init contact_searchform/models/init.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang(Unix) ). If you don't needs a execution permission then remove it with: chmod -x init.py Module contact_search_form.models.contact_search contact_search_form/models/contact_search.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*- contact_search_form/models/contactsearch.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang(Unix) ). If you don't needs a execution permission then remove it with: chmod -x contact_search.py contact_search_form/models/contact_search.py:28: [W8104(api-one-deprecated), SearchLine._compute_record_name] api.one deprecated Module website_contact_extend website_contact_extend/init.py:1: [C7902(missing-readme), ] Missing ./README.rst file. Template here: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst website_contact_extend/data/email_templates.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline website_contact_extend/views/contact_report.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline website_contact_extend/views/res_partner.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline website_contact_extend/views/website_contact.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline website_contact_extend/readme/USAGE.rst:1: [W7908(missing-newline-extrafiles), ] Missing newline Module website_contact_extend.manifest website_contact_extend/manifest.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*- website_contact_extend/manifest.py:7: [C8106(manifest-version-format), ] Wrong Version Format "11.0.1.0.0" in manifest file. Regex to match: "(10.0).\d+.\d+.\d+$" Module website_contact_extend.controllers.myfilter website_contact_extend/controllers/myfilter.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or `# -- coding: utf-8 --` Module website_contact_extend.models.res_partner website_contact_extend/models/res_partner.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*-

And runbot 2018-10-08 14:15:08,841 186 WARNING openerp_test odoo.addons.base.module.module: module contact_search_form: description is empty ! 2018-10-08 14:15:09,600 186 WARNING openerp_test odoo.addons.base.module.module: module website_contact_extend: description is empty !

With that fixed, let's move forward and look for other contributions to rise!

— You are receiving this because you were mentioned. Reply to this email directly, [ https://github.com/OCA/data-protection/pull/10#issuecomment-429888678 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/Amnv_Lu1oUK9-VtRxqAe2LlLe2bqsuioks5ulKLvgaJpZM4U0Elc | mute the thread ] .

ITISAG-OCA commented 6 years ago

Dear Mr. Baeza,

as i mentioned in my message earlier this week i'm wondering if the OCA/data-protection branch 11.0 is still using Odoo 10 to run automated tests. If so a lot of the technical warnings that were the result of those tests would have to be reintegrated like the two issues mentioned below. A response would be very welcome.

Best Regards Sven Hartmann IT IS AG

From: "Support" support@itis.de To: "OCA" reply@reply.github.com Cc: "projectmanagement" projectmanagement@itis.de Sent: Tuesday, October 16, 2018 10:51:40 AM Subject: Re: [OCA/data-protection] GDPR Module for OCA V11 (#10)

Dear Mr. Baeza,

we have updated the modules based on the list below. However i have doubts concerning the following two issues as both are indicating that the tests running on OCA/data-protection branch 11.0 are executed in an Odoo 10 environment: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*- [C8106(manifest-version-format), ] Wrong Version Format "11.0.1.0.0" in manifest file. Regex to match: "(10.0).\d+.\d+.\d+$"

The modules we provided are intended for the branch 11.0.

Best regards

Sven Hartmann IT IS AG

From: "Pedro M. Baeza" notifications@github.com To: "OCA/data-protection" data-protection@noreply.github.com Cc: "oca" oca@itis.de, "Mention" mention@noreply.github.com Sent: Monday, October 15, 2018 5:00:00 PM Subject: Re: [OCA/data-protection] GDPR Module for OCA V11 (#10)

Joerg, there's no need of including us in copy in the mail. We receive the same notification from GitHub.

Thanks for your comments. We are not going to be more picky about the features for not discouraging you on your contribution. Let's focus now on the technical part. There are several minimum fails and warnings on CIs:

flake8: contact_search_form/manifest.py:10:80: E501 line too long (98 > 79 characters) contact_search_form/models/contact_search.py:43:5: E124 closing bracket does not match visual indentation contact_search_form/models/contact_search.py:47:5: E124 closing bracket does not match visual indentation

pylint Using config file /home/travis/maintainer-quality-tools/travis/cfg/travis_run_pylint.cfg Module contact_search_form contact_searchform/init.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang(Unix) ). If you don't needs a execution permission then remove it with: chmod -x init.py contact_search_form/init.py:1: [C7902(missing-readme), ] Missing ./README.rst file. Template here: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst contact_search_form/security/gdpr_security.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline Module contact_search_form.manifest contact_search_form/manifest.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*- contact_searchform/manifest.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang(Unix) ). If you don't needs a execution permission then remove it with: chmod -x manifest.py Module contact_search_form.models.init contact_searchform/models/init.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang(Unix) ). If you don't needs a execution permission then remove it with: chmod -x init.py Module contact_search_form.models.contact_search contact_search_form/models/contact_search.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*- contact_search_form/models/contactsearch.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang(Unix) ). If you don't needs a execution permission then remove it with: chmod -x contact_search.py contact_search_form/models/contact_search.py:28: [W8104(api-one-deprecated), SearchLine._compute_record_name] api.one deprecated Module website_contact_extend website_contact_extend/init.py:1: [C7902(missing-readme), ] Missing ./README.rst file. Template here: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst website_contact_extend/data/email_templates.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline website_contact_extend/views/contact_report.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline website_contact_extend/views/res_partner.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline website_contact_extend/views/website_contact.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline website_contact_extend/readme/USAGE.rst:1: [W7908(missing-newline-extrafiles), ] Missing newline Module website_contact_extend.manifest website_contact_extend/manifest.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*- Module website_contact_extend.controllers.myfilter website_contact_extend/controllers/myfilter.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or `# -- coding: utf-8 --` Module website_contact_extend.models.res_partner website_contact_extend/models/res_partner.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*-

Using config file /home/travis/maintainer-quality-tools/travis/cfg/travis_run_pylint_pr.cfg Module contact_search_form contact_searchform/init.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang(Unix) ). If you don't needs a execution permission then remove it with: chmod -x init.py contact_search_form/init.py:1: [C7902(missing-readme), ] Missing ./README.rst file. Template here: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst contact_search_form/security/gdpr_security.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline Module contact_search_form.manifest contact_search_form/manifest.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*- contact_searchform/manifest.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang(Unix) ). If you don't needs a execution permission then remove it with: chmod -x manifest.py contact_search_form/manifest.py:7: [C8106(manifest-version-format), ] Wrong Version Format "11.0.1.0.0" in manifest file. Regex to match: "(10.0).\d+.\d+.\d+$" Module contact_search_form.models.init contact_searchform/models/init.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang(Unix) ). If you don't needs a execution permission then remove it with: chmod -x init.py Module contact_search_form.models.contact_search contact_search_form/models/contact_search.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*- contact_search_form/models/contactsearch.py:1: [W8201(incoherent-interpreter-exec-perm), ] You have a python file with execution permissions but you don't have a interpreter magic comment. If you really needs a execution permission then add a magic comment ( https://en.wikipedia.org/wiki/Shebang(Unix) ). If you don't needs a execution permission then remove it with: chmod -x contact_search.py contact_search_form/models/contact_search.py:28: [W8104(api-one-deprecated), SearchLine._compute_record_name] api.one deprecated Module website_contact_extend website_contact_extend/init.py:1: [C7902(missing-readme), ] Missing ./README.rst file. Template here: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst website_contact_extend/data/email_templates.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline website_contact_extend/views/contact_report.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline website_contact_extend/views/res_partner.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline website_contact_extend/views/website_contact.xml:1: [W7908(missing-newline-extrafiles), ] Missing newline website_contact_extend/readme/USAGE.rst:1: [W7908(missing-newline-extrafiles), ] Missing newline Module website_contact_extend.manifest website_contact_extend/manifest.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*- website_contact_extend/manifest.py:7: [C8106(manifest-version-format), ] Wrong Version Format "11.0.1.0.0" in manifest file. Regex to match: "(10.0).\d+.\d+.\d+$" Module website_contact_extend.controllers.myfilter website_contact_extend/controllers/myfilter.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or `# -- coding: utf-8 --` Module website_contact_extend.models.res_partner website_contact_extend/models/res_partner.py:1: [C8201(no-utf8-coding-comment), ] No UTF-8 coding comment found: Use # coding: utf-8 or # -*- coding: utf-8 -*-

And runbot 2018-10-08 14:15:08,841 186 WARNING openerp_test odoo.addons.base.module.module: module contact_search_form: description is empty ! 2018-10-08 14:15:09,600 186 WARNING openerp_test odoo.addons.base.module.module: module website_contact_extend: description is empty !

With that fixed, let's move forward and look for other contributions to rise!

— You are receiving this because you were mentioned. Reply to this email directly, [ https://github.com/OCA/data-protection/pull/10#issuecomment-429888678 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/Amnv_Lu1oUK9-VtRxqAe2LlLe2bqsuioks5ulKLvgaJpZM4U0Elc | mute the thread ] .

pedrobaeza commented 6 years ago

Hi, Sven, sorry, I didn't see it, because I'm begging you since 2 messages ago that please don't reply from mail without removing the quoted text, or this is very difficult to read between so long texts.

Indeed, the branch configuration is incorrect. I have already fixed it. Please rebase.

ITISAG-OCA commented 6 years ago

Hello Pedro,

i'm sorry for the long emails, it seems i did not notice your request to remove the quotes. The messages were indeed to long navigate efficiently. I will keep that in mind in the future. I also saw the change in the data-protection branch 11, thank you, and changed the module files accordingly. From what i saw the builds did pass the checks this time.

Regards Sven Hartmann IT IS AG

From: "Pedro M. Baeza" notifications@github.com To: "OCA/data-protection" data-protection@noreply.github.com Cc: "oca" oca@itis.de, "Mention" mention@noreply.github.com Sent: Saturday, October 20, 2018 5:15:49 PM Subject: Re: [OCA/data-protection] GDPR Module for OCA V11 (#10)

Hi, Sven, sorry, I didn't see it, because I'm begging you since 2 messages ago that please don't reply from mail without removing the quoted text, or this is very difficult to read between so long texts.

Indeed, the branch configuration is incorrect. I have already fixed it. Please rebase.

— You are receiving this because you were mentioned. Reply to this email directly, [ https://github.com/OCA/data-protection/pull/10#issuecomment-431590147 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/Amnv_FkoEpydnlEtss7nNpzaLUiqkY8mks5umz4lgaJpZM4U0Elc | mute the thread ] .

pedrobaeza commented 6 years ago

Well, you still continue including quoted text in your replies, but let's merge this PR and welcoming other contributions.