Closed njeudy closed 5 years ago
What if we open a "Detials" page, where "Subjects" is a subsection, and "Processors" is another one, and more sections can be added or removed?
What if we open a "Detials" page, where "Subjects" is a subsection, and "Processors" is another one, and more sections can be added or removed?
Hum, think we can do this but details will be a big page because I need to add some details:
"Where processing is to be carried out on behalf of a controller, the controller shall use only processors providing sufficient guarantees to implement appropriate technical and organisational measures in such a manner that processing will meet the requirements of this Regulation and ensure the protection of the rights of the data subject"
I wish to manage this on each activity. So activities form can be complex.
Here is a type of document I wish to achieve for each activities (in french sorry):
Thanks for the doc.
The kind of data I think can be organizated as follows:
privacy_consent
, which I encourage you to take a look into if you didn't yet :wink:, and it's what concerns me most personally).
Also, besides our comfortability on putting fields somewhere, I want to think on user's comfortability, which means having most important info available at first sight, and a form structure that avoids repeating information.
As a good base addon, this one only provides info contained in point 1. IMHO all that view should be arranged as it was previously.
I.e., for a user, not seeing the subjects or processors until hitting pages 2 and 3 seems like that info is not so important, but it is actually very basic.
You would probably need to add a new tab for point 2 and another for point 3. I also think that point 2 should appear before the description tab, just to make sure the user doesn't fill the description with things that he will have to write again in that other tab.
Point 4 already creates its own page, and it's OK as it is.
Well, this is my POV, and I just ask you to consider it, but I'm not gonna block the PR just because of this! :blush:
ok thanks @Yajo , will keep it on first sight, but add some separators to have a clean form :)
@pedrobaeza @Yajo I update screenshot for after ? remove notebook and add separator.
Is it ok for you ? Will push code if ok :)
Thanks! I like it more. However, I'd still put the description field into its own tab. Just to have a good place where to inject more tabs if needed.
For the base addon, the UX remains the same as there will be only 1 tab. For other addons, this lets them decide if their new fields should have a brand new tab or use one of the provided sections.
@Yajo Done ! @pedrobaeza Any requests ?
Please squash your last 2 commits for merging this.
This PR has the approved
label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
@pedrobaeza done ! thanks for the review
WIP:
Before:
After: