OCA / data-protection

Data Protection
https://github.com/OCA/data-protection/wiki
GNU Affero General Public License v3.0
31 stars 68 forks source link

[12.0][MIG] migration module privacy #21

Closed njeudy closed 5 years ago

njeudy commented 5 years ago

WIP:

Before:

capture d ecran 2019-01-26 10 39 36

After: image

yajo commented 5 years ago

What if we open a "Detials" page, where "Subjects" is a subsection, and "Processors" is another one, and more sections can be added or removed?

njeudy commented 5 years ago

What if we open a "Detials" page, where "Subjects" is a subsection, and "Processors" is another one, and more sections can be added or removed?

Hum, think we can do this but details will be a big page because I need to add some details:

"Where processing is to be carried out on behalf of a controller, the controller shall use only processors providing sufficient guarantees to implement appropriate technical and organisational measures in such a manner that processing will meet the requirements of this Regulation and ensure the protection of the rights of the data subject"

I wish to manage this on each activity. So activities form can be complex.

Here is a type of document I wish to achieve for each activities (in french sorry):

registre_rgpd_basique.pdf

yajo commented 5 years ago

Thanks for the doc.

The kind of data I think can be organizated as follows:

  1. Basic activity information:
    • Activity name
    • Subjects
    • Controller
    • Processors
    • Description
  2. Info about contents of the processed data:
    • Objectives
    • Subject Categories
    • Data categories
    • Transfer out of UE
  3. Data security:
    • Measures
    • Breaches
    • Audits
    • Etc.
  4. Consent (this one comes from v10's privacy_consent, which I encourage you to take a look into if you didn't yet :wink:, and it's what concerns me most personally).
    • Wether to ask for it or not.
    • Default acceptance status
    • Email template
    • Consents sent/received
    • Other configs

Also, besides our comfortability on putting fields somewhere, I want to think on user's comfortability, which means having most important info available at first sight, and a form structure that avoids repeating information.

As a good base addon, this one only provides info contained in point 1. IMHO all that view should be arranged as it was previously.

I.e., for a user, not seeing the subjects or processors until hitting pages 2 and 3 seems like that info is not so important, but it is actually very basic.

You would probably need to add a new tab for point 2 and another for point 3. I also think that point 2 should appear before the description tab, just to make sure the user doesn't fill the description with things that he will have to write again in that other tab.

Point 4 already creates its own page, and it's OK as it is.

Well, this is my POV, and I just ask you to consider it, but I'm not gonna block the PR just because of this! :blush:

njeudy commented 5 years ago

ok thanks @Yajo , will keep it on first sight, but add some separators to have a clean form :)

njeudy commented 5 years ago

@pedrobaeza @Yajo I update screenshot for after ? remove notebook and add separator.

Is it ok for you ? Will push code if ok :)

yajo commented 5 years ago

Thanks! I like it more. However, I'd still put the description field into its own tab. Just to have a good place where to inject more tabs if needed.

For the base addon, the UX remains the same as there will be only 1 tab. For other addons, this lets them decide if their new fields should have a brand new tab or use one of the provided sections.

njeudy commented 5 years ago

@Yajo Done ! @pedrobaeza Any requests ?

pedrobaeza commented 5 years ago

Please squash your last 2 commits for merging this.

OCA-git-bot commented 5 years ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

njeudy commented 5 years ago

@pedrobaeza done ! thanks for the review