[12.0][FIX] privacy_consent: do not mark as sent if mail failed

OCA / data-protection

Data Protection

https://github.com/OCA/data-protection/wiki

GNU Affero General Public License v3.0

31 stars 68 forks source link

Closed yajo closed 4 years ago

yajo commented 4 years ago

Due to a bug present in the _postprocess_sent_message code, if a consent wasn't successfully sent, still the consent got marked as sent.

It should stay as draft. Modify tests to test this new behavior.

@Tecnativa TT24457

yajo commented 4 years ago

https://github.com/OCA/social/pull/557 was causing some integration failures. Those shouldn't happen with this code anymore.

yajo commented 4 years ago

This is ready to merge

pedrobaeza commented 4 years ago

/ocabot merge patch

OCA-git-bot commented 4 years ago

This PR looks fantastic, let's merge it! Prepared branch 12.0-ocabot-merge-pr-42-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 4 years ago

Congratulations, your PR was merged at fa9fb5386989e987bd6c34f5e28c75974588e185. Thanks a lot for contributing to OCA. ❤️