OCA / data-protection

Data Protection
https://github.com/OCA/data-protection/wiki
GNU Affero General Public License v3.0
31 stars 68 forks source link

[13.0][MIG] privacy #43

Closed techultrasolutions closed 3 years ago

techultrasolutions commented 4 years ago

Data Privacy and Protection

This application provides data protection and privacy feature, to comply with regulations such as GDPR.

techultrasolutions commented 4 years ago

@pedrobaeza @dreispt Would you please review this PR?

techultrasolutions commented 4 years ago

@pedrobaeza @dreispt Would you please review this PR?

@pedrobaeza ping

pedrobaeza commented 4 years ago

Sorry, I don't know enough the module for functional review, but in a first glance, you haven't followed the migration guide:

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0

that states that you have to do the pre-commit stuff in one first commit.

Please change that and I'll do code review later, and my colleague @Yajo may review it functionally.

techultrasolutions commented 4 years ago

Sorry, I don't know enough the module for functional review, but in a first glance, you haven't followed the migration guide:

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0

that states that you have to do the pre-commit stuff in one first commit.

Please change that and I'll do code review later, and my colleague @Yajo may review it functionally.

@pedrobaeza Above mentioned points are done.

techultrasolutions commented 4 years ago

@max3903 Please Review.

yajo commented 4 years ago

This doesn't look good. It's the activities form:

imagen

yajo commented 3 years ago

I was pushing an alternate PR and accidentally I pushed https://github.com/OCA/data-protection/commit/16b58ea2a6a591b1fb2051bbff8e5960fe6272c5 to the main 13.0 branch 🙈. I was testing odoo-module-migrator and got bit by https://github.com/OCA/odoo-module-migrator/pull/47, which I hope is merged soon.

I'm very sorry for that, but it's done already, so I'll close this PR. If there's anything to change, please open a new one.