[FIX] privacy_consent: make it work, basically

[yajo]

Some little nasty details were overlooked in the v12 migration, due to https://github.com/odoo/odoo/commit/6eda1dcb7a923ed31a68fa0a3aaf3f275c844a7d renaming send_get_mail_body, which rendered the module basically useless:

• The wizard used to ask for consent in manual activities did not fill the placeholders, resulting in an awkward UX.

  Before	After

• The sent mails did not have the token to authenticate and actually allow accepting or rejecting. These buttons returned a 500 error.

  Before	After

• Once the token is added, the form was ugly.

  Before	After

• Sadly, some tests were testing the how and not the what. It is understandable due to the complexity of testing the what, even more without the Form utility, new on v12. These are fixed now too.

@Tecnativa TT25868

[pedrobaeza]

Please check Travis

[yajo]

Sorry but changes don't solve problem, if you test in runbot can see accept/reject urls in mails.

Are you sure?

It's important that you understand that the message logged in the chatter is one thing, and the mail sent to the subject partner is another thing. The tokenized URL is only sent to the subject partner, and that's on purpose because otherwise anybody reading the chatter could impersonate him and accept/reject data treatment.

The only way for you to see the sent mail is to use mailhog or similar, and there you can see the token, just like in the picture in https://github.com/OCA/data-protection/pull/47#issue-499370217.

[yajo]

Please check Travis

Thanks, linter fixed. Sorry, I'm used to pre-commit these days. :laughing:

[yajo]

/ocabot merge minor

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it! Prepared branch 12.0-ocabot-merge-pr-47-by-Yajo-bump-minor, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 124f2faabe0865be97f60a5a4fd29f0acf9d9d9d. Thanks a lot for contributing to OCA. ❤️