search

OCA / data-protection

Data Protection
https://github.com/OCA/data-protection/wiki
GNU Affero General Public License v3.0
31 stars 68 forks source link

[MIG] privacy_consent: migrate to 16.0 #71

Closed tde-banana-odoo closed 1 year ago

tde-banana-odoo commented 2 years ago

Waiting https://github.com/OCA/data-protection/pull/70

pedrobaeza commented 2 years ago

/ocabot migration privacy_consent

You can now rebase the PR after merging the dependent one.

tde-banana-odoo commented 2 years ago

@pedrobaeza CIs are yelling about development_status that is incompatible (beta for privacy, stable for privacy_content). I updated privacy to be in "Production/Stable", is it problematic ?

pedrobaeza commented 2 years ago

Oh, indeed the inconsistency came from where the linter was not activated. Can you please isolate the development status promotion into a separate commit [IMP] privacy: Promote to stable or similar?

tde-banana-odoo commented 2 years ago

Hello,

There was a "hackish" fix to do due to removal of t-raw when displaying the html version of a partner's address . Issue is that we have to markup the html content before rendering it, we cannot directly inject html in templates anymore. I made a specific commit as it is not obvious, and maybe deserves its own review https://github.com/OCA/data-protection/pull/71/commits/c90d4dd6df0c77c7b850355a3d904dd54e5aa3ad .

OCA-git-bot commented 1 year ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza commented 1 year ago

/ocabot merge nobump

OCA-git-bot commented 1 year ago

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-71-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at 658b9fcdea7de498936c05396177935070667e1f. Thanks a lot for contributing to OCA. ❤️