[16.0][IMP] privacy_consent: use consteq, add some security tests

OCA / data-protection

Data Protection

https://github.com/OCA/data-protection/wiki

GNU Affero General Public License v3.0

31 stars 68 forks source link

[16.0][IMP] privacy_consent: use consteq, add some security tests #72

Closed tde-banana-odoo closed 1 year ago

tde-banana-odoo commented 2 years ago

Add some security-related tests

Use consteq for tokens comparison to lessen potential attacks using timing

pedrobaeza commented 2 years ago

I suppose this one supersedes #71, isn't it? Please ping when ready to be reviewed.

tde-banana-odoo commented 2 years ago

Hello,

Indeed, waiting for https://github.com/OCA/data-protection/pull/71 to be merged. This one just adds some new commits. I will ping and set to "ready for review" once ready, that's why it is still in draft :) .

Cheers !

pedrobaeza commented 1 year ago

You can rebase over #74 to get green pre-commit.

tde-banana-odoo commented 1 year ago

Hello,

Thanks, rebased :) small PR ready for review then :) .

OCA-git-bot commented 1 year ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-72-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at 9ca6e047715423ab9906b69762cab58b804f0c0d. Thanks a lot for contributing to OCA. ❤️