OCA / delivery-carrier

Odoo Carriers And Deliveries Management
https://odoo-community.org/psc-teams/logistics-18
GNU Affero General Public License v3.0
112 stars 351 forks source link

[14.0][ADD] delivery_price_collection_cost: new module #831

Closed aleuffre closed 3 months ago

aleuffre commented 3 months ago

New module to track collection costs separately from the rest of the shipping cost, with a different product and price.

PR also contains a small bridge module between itself and delivery_price_product_domain, as well as a small change to delivery_price_rule_untaxed necessary to make the bridge module work.

Todo:

rousseldenis commented 3 months ago

@aleuffre Isn't that covered by landed_costs ? https://www.odoo.com/documentation/17.0/fr/applications/inventory_and_mrp/inventory/warehouses_storage/inventory_valuation/integrating_landed_costs.html

francesco-ooops commented 3 months ago

@rousseldenis looks complicated. Does that allow to set landed costs per sale order, and relate them to a shipping method?

Use case here is "cash on delivery", where carrier collects SO amount, and takes a fixed fee (fee varies according to shipping rules)

Eg: if order value < 300, delivery costs = 8 (collection fee) + 3% order value if order value >= 300, delivery costs = 16 (collection fee) + 3% order value

francesco-ooops commented 3 months ago

Actually to expand the use case: "free delivery" promotion can be applied to a specific SO, but collection costs should be excluded from the promotion.

francesco-ooops commented 3 months ago

@pedrobaeza all ready for nobump :)

OCA-git-bot commented 3 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza commented 3 months ago

/ocabot merge nobump

OCA-git-bot commented 3 months ago

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-831-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 3 months ago

Congratulations, your PR was merged at e5f16574e559baeb67e51b6848ad9f6b4c8541e8. Thanks a lot for contributing to OCA. ❤️