OCA / delivery-carrier

Odoo Carriers And Deliveries Management
https://odoo-community.org/psc-teams/logistics-18
GNU Affero General Public License v3.0
112 stars 351 forks source link

[16.0][BC] base_delivery_carrier_label: remove _set_a_default_package #853

Open hparfr opened 2 months ago

hparfr commented 2 months ago

This functionality adds a burden on other modules tests like (delivery_package_fee or delivery_package_number).

In some contexts, you want to require a package to be always explicitly created.

This functionality is also now implemented in delivery_automatic_package module.

To be merged with major

EDIT:

Contains and replace:

~~This PR remove set_a_default_package from base_delivery_carrier_label. Tests are red because it needs some changes in delivery_roulier #855 And tests in #855 are also red because it needs this PR.~~

hparfr commented 2 months ago

@rousseldenis please have a look. It remplace https://github.com/OCA/delivery-carrier/pull/643

rousseldenis commented 2 months ago

@hparfr Could you fix also roulier module here ?

hparfr commented 2 months ago

@rousseldenis is it possible to ocabot merge major on two modules in the same PR ?

rousseldenis commented 2 months ago

@rousseldenis is it possible to ocabot merge major on two modules in the same PR ?

I think so

hparfr commented 2 months ago

@rousseldenis Both commit added to this pr;

hparfr commented 1 month ago

@rousseldenis is it ok for you to merge this PR ?