search

OCA / delivery-carrier

Odoo Carriers And Deliveries Management
https://odoo-community.org/psc-teams/logistics-18
GNU Affero General Public License v3.0
112 stars 351 forks source link

[FIX] base_delivery_carrier_label: compute the weight by the product weight #856

Closed yankinmax closed 2 months ago

yankinmax commented 2 months ago

@florian-dacosta can you pls take a look?

yankinmax commented 2 months ago

@florian-dacosta do you want me to change the tests? They seem OK for me.

florian-dacosta commented 2 months ago

Hum, I went too fast, I did not see the test was failing... I'll take a look

florian-dacosta commented 2 months ago

@yankinmax I made a PR on your branch to fix the tests.

yankinmax commented 2 months ago

@florian-dacosta you rock!! Why didn't I check product types?? :smile:

gurneyalex commented 2 months ago

/ocabot merge patch

OCA-git-bot commented 2 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 17.0-ocabot-merge-pr-856-by-gurneyalex-bump-patch, awaiting test results.

OCA-git-bot commented 2 months ago

Congratulations, your PR was merged at 07d5ad854a32a73ebbc518679c7188d674102b93. Thanks a lot for contributing to OCA. ❤️