search

OCA / delivery-carrier

Odoo Carriers And Deliveries Management
https://odoo-community.org/psc-teams/logistics-18
GNU Affero General Public License v3.0
112 stars 351 forks source link

[FIX] base_delivery_carrier_label test decorators #862

Closed gurneyalex closed 1 month ago

gurneyalex commented 1 month ago

Previous fix was incomplete: the class method should only call other class methods

yankinmax commented 1 month ago

@gurneyalex I've used your fix and tried to rewrite tests for delivery_roulier_chronopost_fr As I've written here https://github.com/OCA/delivery-carrier/pull/830#issuecomment-2233782397 finally I think we shouldn't inherit from this test.

gurneyalex commented 1 month ago

@gurneyalex I've used your fix and tried to rewrite tests for delivery_roulier_chronopost_fr As I've written here #830 (comment) finally I think we shouldn't inherit from this test.

I will still get this merged, to have some correct code in the module.

gurneyalex commented 1 month ago

/ocabot merge patch

OCA-git-bot commented 1 month ago

On my way to merge this fine PR! Prepared branch 17.0-ocabot-merge-pr-862-by-gurneyalex-bump-patch, awaiting test results.

OCA-git-bot commented 1 month ago

Congratulations, your PR was merged at ba074840892b47cb031dd0c9a86b8f34a70950f9. Thanks a lot for contributing to OCA. ❤️