search

OCA / delivery-carrier

Odoo Carriers And Deliveries Management
https://odoo-community.org/psc-teams/logistics-18
GNU Affero General Public License v3.0
112 stars 351 forks source link

[REF] Remove deb package added by accident #864

Closed dreispt closed 1 month ago

pedrobaeza commented 1 month ago

Doing this, there's a diff of 60 MB instead of 30. A forced push should be done instead for removing this cleanly.

rousseldenis commented 1 month ago

Mmmmh, a force push is not wanted. @sbidoul Any advice ?

sbidoul commented 1 month ago

Doing this, there's a diff of 60 MB instead of 30. A forced push should be done instead for removing this cleanly.

FWIW:

❯ du -h .git --max-depth=0 50M .git ❯ git rm *.deb ❯ git commit -m "remove .deb file" ❯ du -h .git --max-depth=0 50M .git

So IMHO, this PR is better than the status quo.

pedrobaeza commented 1 month ago

I did the same experiment in a fork, and once pushed seems to be the problem. But anyway, I'm going to do the cleanup this week as said, previously announcing it in the contributors list.

sbidoul commented 1 month ago

But anyway, I'm going to do the cleanup this week as said, previously announcing it in the contributors list.

@pedrobaeza I think we need more evidence that this is worthwhile before doing such a disruptive operation.

pedrobaeza commented 1 month ago

Even if the removal doesn't add size, the inclusion of deb files does, so it must be cleaned.

sbidoul commented 1 month ago

Even if the removal doesn't add size, the inclusion of deb files does, so it must be cleaned.

Well, must is a big word and the tradeoffs are not that all obvious to me. Please make sure to provide data and gather consensus on the contributors mailing list before doing any force push.

pedrobaeza commented 1 month ago

Yes, because we are wasting a lot of resources. The trade-offs are very little and have direct mitigation actions. That's why I'm so categorical.