search

OCA / donation

GNU Affero General Public License v3.0
21 stars 87 forks source link

[14.0][MIG] donation_direct_debit #91

Closed alexis-via closed 2 years ago

alexis-via commented 3 years ago

Requires PR https://github.com/OCA/donation/pull/89

The migration is made from v10 because I figured out that commit history was lost during the v11 migration, cf https://github.com/OCA/donation/pull/53

Improve chatter message to add a link to the payment order

Don't give rights on account.payment.order or account.payment.line to Donation User group because rights on payment orders should be very restricted. Use sudo() to create the payment order & line in the code.

I'm really happy with change n°3 discussed on https://github.com/OCA/donation/issues/84 : it simplifies this module as payment_mode_id is already present on donation.donation!

OCA-git-bot commented 3 years ago

Hi @alexis-via! Thank you very much for this contribution. As the addon you are improving does not have a declared maintainer, I take the opportunity to mention that you can consider adopting it. To do so, please read the maintainer role description, and, if interested, create a pull request to add your GitHub login to the maintainers key of the addon manifest.

alexis-via commented 2 years ago

/ocabot merge nobump

OCA-git-bot commented 2 years ago

This PR looks fantastic, let's merge it! Prepared branch 14.0-ocabot-merge-pr-91-by-alexis-via-bump-nobump, awaiting test results.

OCA-git-bot commented 2 years ago

It looks like something changed on 14.0 in the meantime. Let me try again (no action is required from you). Prepared branch 14.0-ocabot-merge-pr-91-by-alexis-via-bump-nobump, awaiting test results.

OCA-git-bot commented 2 years ago

It looks like something changed on 14.0 in the meantime. Let me try again (no action is required from you). Prepared branch 14.0-ocabot-merge-pr-91-by-alexis-via-bump-nobump, awaiting test results.

OCA-git-bot commented 2 years ago

Congratulations, your PR was merged at db1d9e49749c71d83089bc096d58add6530b2d84. Thanks a lot for contributing to OCA. ❤️