search

OCA / e-commerce

Odoo E-Commerce server automation addons
GNU Affero General Public License v3.0
170 stars 493 forks source link

[16.0][MIG] website_sale_product_assortment: Migration to version 16.0 #873

Closed pilarvargas-tecnativa closed 12 months ago

pilarvargas-tecnativa commented 1 year ago

cc @Tecnativa TT44381

@CarlosRoca13 @chienandalu please review

pilarvargas-tecnativa commented 1 year ago

ping @CarlosRoca13

pilarvargas-tecnativa commented 1 year ago

ping @pedrobaeza :)

pedrobaeza commented 12 months ago

/ocabot migration website_sale_product_assortment /ocabot merge nobump

OCA-git-bot commented 12 months ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 16.0-ocabot-merge-pr-873-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 12 months ago

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-873-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot commented 12 months ago

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-873-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

pilarvargas-tecnativa commented 12 months ago

ping @pedrobaeza

pedrobaeza commented 12 months ago

/ocabot merge nobump

OCA-git-bot commented 12 months ago

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-873-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 12 months ago

Congratulations, your PR was merged at e27062b82c0a69309222331533c14e0e15f80f92. Thanks a lot for contributing to OCA. ❤️

xAdrianCif commented 12 months ago

Hello @CarlosRoca13 and @chienandalu , just out of ignorance and looking to improve in the future, what are the reasons for having validated and merged this PR and having ignored another one with the same code dated earlier even though it was cited?

Thank you!

https://github.com/OCA/e-commerce/pull/854

CarlosRoca13 commented 12 months ago

Hello @xAdrianCif and @suker, apologies for the inconvenience. We didn't notice the notifications in the email, and since we have the company's internal pull requests tracked, we have reviewed this one without checking if there was any previous one. Nevertheless, it's not easy to find the pull request by searching for the module name, as underscores haven't been used. If you enter the name correctly in the search, your pull request doesn't appear.

image

xAdrianCif commented 12 months ago

Understood, thank you @CarlosRoca13 .