OCA / e-commerce

Odoo E-Commerce server automation addons
GNU Affero General Public License v3.0
170 stars 493 forks source link

[16.0][IMP] website_sale_product_attribute_value_filter_existing: adds filter extraction in mobile view #932

Closed lef-adhoc closed 5 months ago

lef-adhoc commented 5 months ago

The mobile view had not been taken into account and the filters appeared even though no product had this filter.

pilarvargas-tecnativa commented 5 months ago

Please put odoo version 16.0 in the title, thanks!

pilarvargas-tecnativa commented 5 months ago

Can you explain about your test to get to the mistake? I can't seem to replicate it in mobile view. Have you changed the template with the editor? Thanks

lef-adhoc commented 5 months ago

@pilarvargas-tecnativa Hello, I detail the steps below Here create an attribute with two values: image Here I assign one of the attribute values to a product: image Then in the store in desktop view it works fine, it does not have the Test 2 attribute: image But in the mobile view it does have the Test 2 attribute: image Here is how it looks like from the cell phone: image

pilarvargas-tecnativa commented 5 months ago

Thank you very much!

On further review, this should also be added for ‘Select’ attributes

image

lef-adhoc commented 5 months ago

@pilarvargas-tecnativa This is working for select attributes image image image

pilarvargas-tecnativa commented 5 months ago

Ok, I have repeated the test locally without the rest of the modules and that way it is correct. The error in my screenshot is due to website _sale_attribute_filter_form_submit. This will have to be taken into account if both modules are used to make a bridge module to make them compatible. Thanks

@pedrobaeza Would it be appropriate to include the bridge module suggestion in the roadmap?

pedrobaeza commented 5 months ago

@miguel-S73 maybe it's something to fix in the module website_sale_attribute_filter_form_submit?

lef-adhoc commented 5 months ago

@pedrobaeza Hello, will there be any news about this?

OCA-git-bot commented 5 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-932-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot commented 5 months ago

Congratulations, your PR was merged at 828ce541fe6e5ea2c1b6ad08436e46d74e5a0529. Thanks a lot for contributing to OCA. ❤️