[16.0][FIX] website_sale_product_attachment: product template view ad…

OCA / e-commerce

Odoo E-Commerce server automation addons

GNU Affero General Public License v3.0

170 stars 494 forks source link

[16.0][FIX] website_sale_product_attachment: product template view ad… #944

Closed miguelcb2003 closed 4 months ago

miguelcb2003 commented 5 months ago

This solution fixes a bug incorpored at https://github.com/OCA/e-commerce/commit/7f6d3e53bd0b33c98bff8fd239ed3a7f491851c0 which produces that the alert and table introduced for product templete view didn't show properly.

With this adjustment, both of them are restricted using a colspan, making them fill the correct grid boxes.

FL-556-3020

OCA-git-bot commented 5 months ago

Hi @Yajo, some modules you are maintaining are being modified, check this out!

OCA-git-bot commented 4 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza commented 4 months ago

Please remove the unneeded changes in the 2 first files.

miguelcb2003 commented 4 months ago

Hi @pedrobaeza, you 're right. I revert all the unneeded changes so it will be only the bugfix inside the PR. Thanks!

OCA-git-bot commented 4 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-944-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot commented 4 months ago

Congratulations, your PR was merged at f0d58b3068f4f961a8944e6cd8ccd5f478296e9a. Thanks a lot for contributing to OCA. ❤️