Closed JordiMForgeFlow closed 1 day ago
Hi @etobella, @simahawk, some modules you are maintaining are being modified, check this out!
@simahawk @etobella @MiquelRForgeFlow ready for review :)
@JordiMForgeFlow LG. Could you please update the blacklist of PRs? If you are not using oca-port you can update the file manually, like https://github.com/OCA/edi/blob/14.0/.oca/oca-port/blacklist/edi_oca.json
@simahawk what is expected to be included in this blacklist? The PRs that have been FW?
My bad. Short answer is: no. Lemme rephrase: is there any PR that shouldn't be fwd ported or that has been partially fwd ported here (eg: leaving behind irrelevant commits)? If yes, we should blacklist them to not get bothered the next time we run oca-port to check what's needed to be ported. Hope is clear now! :blush:
@simahawk Then I don't think we need to add anything, as I have included everything that was missing from V16. I actually also included them in the V18 migration PR: https://github.com/OCA/edi-framework/pull/115
I can see you merged https://github.com/OCA/edi-framework/pull/93 a couple of days ago, I could add it here as well if it looks good to you :)
@JordiMForgeFlow ok, beautiful!
@simahawk we will need to have https://github.com/OCA/edi/pull/1071 merged
@JordiMForgeFlow hey, since I was in a hurry, I opened a new PR based on your PR, where I also rebased the branch against branch 17.0
and migrated a few of the forward-ported commits
@SilvioC2C fine for me :)
In the migration to V17 several commits were left behind in V16.
Depends on https://github.com/OCA/queue/pull/705
CC @etobella @simahawk