OCA / edi-framework

GNU Affero General Public License v3.0
7 stars 29 forks source link

[17.0][FW] edi_oca: missing FW from 16.0 #118

Closed JordiMForgeFlow closed 1 day ago

JordiMForgeFlow commented 1 month ago

In the migration to V17 several commits were left behind in V16.

Depends on https://github.com/OCA/queue/pull/705

CC @etobella @simahawk

OCA-git-bot commented 1 month ago

Hi @etobella, @simahawk, some modules you are maintaining are being modified, check this out!

JordiMForgeFlow commented 1 month ago

@simahawk @etobella @MiquelRForgeFlow ready for review :)

simahawk commented 2 weeks ago

@JordiMForgeFlow LG. Could you please update the blacklist of PRs? If you are not using oca-port you can update the file manually, like https://github.com/OCA/edi/blob/14.0/.oca/oca-port/blacklist/edi_oca.json

JordiMForgeFlow commented 1 week ago

@simahawk what is expected to be included in this blacklist? The PRs that have been FW?

simahawk commented 1 week ago

My bad. Short answer is: no. Lemme rephrase: is there any PR that shouldn't be fwd ported or that has been partially fwd ported here (eg: leaving behind irrelevant commits)? If yes, we should blacklist them to not get bothered the next time we run oca-port to check what's needed to be ported. Hope is clear now! :blush:

JordiMForgeFlow commented 1 week ago

@simahawk Then I don't think we need to add anything, as I have included everything that was missing from V16. I actually also included them in the V18 migration PR: https://github.com/OCA/edi-framework/pull/115

I can see you merged https://github.com/OCA/edi-framework/pull/93 a couple of days ago, I could add it here as well if it looks good to you :)

simahawk commented 1 week ago

@JordiMForgeFlow ok, beautiful!

93 can be included, definitely. Thanks!

JordiMForgeFlow commented 1 week ago

@simahawk we will need to have https://github.com/OCA/edi/pull/1071 merged

SilvioC2C commented 1 day ago

@JordiMForgeFlow hey, since I was in a hurry, I opened a new PR based on your PR, where I also rebased the branch against branch 17.0 and migrated a few of the forward-ported commits

JordiMForgeFlow commented 1 day ago

@SilvioC2C fine for me :)