OCA / edi-framework

GNU Affero General Public License v3.0
6 stars 29 forks source link

[16.0][MIG] edi_account_oca #15

Closed OriolMForgeFlow closed 10 months ago

OriolMForgeFlow commented 1 year ago

Moved from edi repository. Standard migration.

OriolMForgeFlow commented 11 months ago

HI @simahawk , I was wondering if you could take a look at this. The error I commented on in the previous PR, with the debug assets enabled, is as follows:

Screenshot from 2023-10-03 09-10-57

It appears when installing the 'edi_account_oca' module and you try to open the Invoicing app.

simahawk commented 11 months ago

Here's the fix https://github.com/OCA/edi-framework/pull/23

OriolMForgeFlow commented 11 months ago

Here's the fix #23

Thank you very much, @simahawk! 😄

This solution resolved the issue with rendering the view. However, a new problem has arisen: the view now appears somewhat disorganized. I also attempted to migrate edi_stock_oca and encountered the same issue.

Examples:

Screenshot from 2023-10-04 09-27-32

Screenshot from 2023-10-04 09-45-28

simahawk commented 11 months ago

Ok, it seems we have to find a better position where to place the buttons.

etobella commented 10 months ago

@OriolMForgeFlow Can you test how it works with this?

https://github.com/OCA/edi-framework/pull/29

On my local repository worked fine

image

OriolMForgeFlow commented 10 months ago

@OriolMForgeFlow Can you test how it works with this?

29

On my local repository worked fine

image

Worked correctly @etobella! When #29 is merged, this PR can also be reviewed.

etobella commented 10 months ago

/ocabot rebase

OCA-git-bot commented 10 months ago

@etobella The rebase process failed, because command git push --force ForgeFlow tmp-pr-15:16.0-mig-edi_account_oca failed with output:

remote: Permission to ForgeFlow/edi-framework.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/ForgeFlow/edi-framework/': The requested URL returned error: 403
pedrobaeza commented 10 months ago

/ocabot migration edi_account_oca

OCA-git-bot commented 10 months ago

There's no issue in this repo with the title 'Migration to version 16.0' and the milestone 16.0, so not possible to add the comment.

pedrobaeza commented 10 months ago

/ocabot merge nobump

OCA-git-bot commented 10 months ago

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-15-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 10 months ago

Congratulations, your PR was merged at 4d8cd6d974595d4ff0d7db9ef5973a8f97890e37. Thanks a lot for contributing to OCA. ❤️