search

OCA / edi-framework

GNU Affero General Public License v3.0
6 stars 29 forks source link

[16.0][MIG] edi_sale_oca: Migration to 16.0 #31

Closed QuocDuong1306 closed 9 months ago

QuocDuong1306 commented 10 months ago

Migrate from:

Depends on:

simahawk commented 10 months ago

In OCA/edi#759, should we need to move listeners.py in edi_sale_ubl_oca to edi_sale_oca for common? Because in the future, maybe we need more modules like edi_sale_ubl_oca (ex: edi_sale_edifact_oca,...)

I'd do it only if we think that setting the state is needed in all the other cases is needed. Otherwise, what would you move? An empty listener for create and write?

What is your POV on this?

QuocDuong1306 commented 10 months ago

Yes @simahawk, you're right. We need to move when all standards need setting the state. So please ignore it and could you review this module? Thank a lot

yvaucher commented 10 months ago

Please squash Simone's commits

fixup! Add edi_sale_oca

fixup! fixup! Add edi_sale_oca

into

Add edi_sale_oca

QuocDuong1306 commented 10 months ago

Hi @yvaucher , I updated. When squashing fixup! fixup! Add edi_sale_oca into Add edi_sale_oca, it was conflicted. So I squash fixup! fixup! Add edi_sale_oca into edi_sale: clean file and change the tile commit to edi_sale: clean file and drop *type_auto dependency. Thanks

simahawk commented 10 months ago

Hi @yvaucher , I updated. When squashing fixup! fixup! Add edi_sale_oca into Add edi_sale_oca, it was conflicted. So I squash fixup! fixup! Add edi_sale_oca into edi_sale: clean file and change the tile commit to edi_sale: clean file and drop *type_auto dependency. Thanks

In theory it should have been squashed on the original PR... :wink:

QuocDuong1306 commented 10 months ago

I updated

simahawk commented 9 months ago

/ocabot rebase

OCA-git-bot commented 9 months ago

Congratulations, PR rebased to 16.0.

simahawk commented 9 months ago

/ocabot merge nobump

simahawk commented 9 months ago

ah well, the OCA infra is down now... won't get any merge

nilshamerlinck commented 9 months ago

@simahawk looks like Alexandre fixed the server issue, so the gitbot should be back, would you mind issuing the command again?

simahawk commented 9 months ago

/ocabot merge nobump

OCA-git-bot commented 9 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-31-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot commented 9 months ago

Congratulations, your PR was merged at 9120150eb4828913bdad665af3bac92c1d49b302. Thanks a lot for contributing to OCA. ❤️