Closed john-herholz-dt closed 1 month ago
Thanks @nguyenminhchien for your in depth review. Will adjust everything later today. Sure I might have forgotten about some essential changes like the name_get. I didn't look into it.
I have applied the suggested changes, all tests now pass.
Hello @simahawk , I know you are busy, but once you have some minutes, could you check this PR, I need to migrate everything to 17.0 and edi_oca is the most critical.
I also saw there was another PR for 16 "add partner form page". Do I need to update the code? Does this work with the git patch command from the migration wiki?
Thank you very much!
I have re-done the migration with the latest changes from 16.0 branch that were not included previously.
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.
@simahawk what are we doing with this?
Can you rebase please for the runboat @john-herholz-dt ?
I did the rebase, somehow it had now problems with the pre-commit checks, I did another one pre-commit on my side
the last commit will be include with the migration commit
I did the rebase, somehow it had now problems with the pre-commit checks, I did another one pre-commit on my side
This PR has the approved
label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
/ocabot merge nobump
What a great day to merge this nice PR. Let's do it! Prepared branch 17.0-ocabot-merge-pr-47-by-gurneyalex-bump-nobump, awaiting test results.
Finally! Jeehaaaa.
Congratulations, your PR was merged at 91b3a7f74439a9e773708973b488f2ef8fad1a1a. Thanks a lot for contributing to OCA. ❤️
A lot of views needed to be adjusted.
Furthermore I changed the _search method on edi_exchange_record, as the count param no longer works. Not sure about the change as I don't know what the override of the _search method was suppossed to do.
Edit: @nguyenminhchien helped on the _search method.