search

OCA / edi-framework

GNU Affero General Public License v3.0
6 stars 26 forks source link

[16.0][IMP] edi_oca: add partner form page #52

Closed QuocDuong1306 closed 6 months ago

QuocDuong1306 commented 6 months ago

Fix the TODO at: https://github.com/OCA/edi-framework/blob/16.0/edi_sale_oca/views/res_partner.xml#L13

OCA-git-bot commented 6 months ago

Hi @simahawk, @etobella, some modules you are maintaining are being modified, check this out!

simahawk commented 6 months ago

I think we can find a solution here: do not touch the other modules. They are adding a group in a specific section, not a page. Just move the view from edi_sale to core. I would also add a TODO in those modules to move their conf to the same page in their own group.

simahawk commented 6 months ago

As you are there, please rewrite the commit as 

[IMP] edi_oca: add partner form page
QuocDuong1306 commented 6 months ago

Thank @simahawk @etobella , I updated

OCA-git-bot commented 6 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot commented 6 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-52-by-etobella-bump-minor, awaiting test results.

OCA-git-bot commented 6 months ago

Congratulations, your PR was merged at 125838d5b5d8a5e8dad3edc60ad89ee705a9bbb8. Thanks a lot for contributing to OCA. ❤️