search

OCA / edi-framework

GNU Affero General Public License v3.0
6 stars 26 forks source link

[16.0] edi_storage_oca: replace use of 'fs_storage' deprecated functions #65

Closed sebalix closed 5 months ago

sebalix commented 5 months ago

Tested with SFTP protocol.

cc @simahawk

sebalix commented 5 months ago

I'm suspecting (but I'm not sure) it was the use of these deprecated methods that triggers connection issues over time. These methods are decorated, and it could be that the decorator is keeping an old reference to self.__fs having a socket that gets closed after some time. That could explain why the "Test connection" button of fs_storage provides the expected result, while the EDI jobs are failing even when requeued.

This will be tested anyway.

simahawk commented 5 months ago

@sebalix can you squash pls?

simahawk commented 5 months ago

/ocabot merge patch

OCA-git-bot commented 5 months ago

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-65-by-simahawk-bump-patch, awaiting test results.

OCA-git-bot commented 5 months ago

Congratulations, your PR was merged at 9285a9f851c59693935fb6b2c64e4d1f1e904e36. Thanks a lot for contributing to OCA. ❤️