search

OCA / edi-framework

GNU Affero General Public License v3.0
6 stars 26 forks source link

[16.0][IMP] edi_storage_oca: do not ignore OSError when getting remote file #70

Open JordiMForgeFlow opened 5 months ago

JordiMForgeFlow commented 5 months ago

When the fs_storage connection fails, it can raise OSError here: https://github.com/OCA/storage/blob/4d82d00aaec818c10dfcfe509d9640d48ebffbf2/fs_storage/models/fs_storage.py#L294.

simahawk commented 4 months ago

But that's not for the file missing, it when you get a conn error. No?

JordiMForgeFlow commented 4 months ago

@simahawk yes, when file is missing we get FileNotFoundError

nilshamerlinck commented 1 month ago

Hello @JordiMForgeFlow fyi I created https://github.com/OCA/edi-framework/pull/88 to iterate over this PR, let me know if you see something that doesn't sound correct to you :)