OCA / edi

GNU Affero General Public License v3.0
119 stars 301 forks source link

[14.0] - pin PyPDF2 version in requirements #655

Closed michelerusti closed 1 year ago

michelerusti commented 2 years ago

I'd like to pin the PyPDF2 version in the requirements.txt file to the same version of the odoo one.

I came across this error when testing a functionality through Travis CI, when installing the requirements, it forces an update to the latest version the the module, loosing the "filters" functionality produicing this log:

Attempting uninstall: PyPDF2
    Found existing installation: PyPDF2 1.26.0
    Uninstalling PyPDF2-1.26.0:
      Successfully uninstalled PyPDF2-1.26.0
Successfully installed PyPDF2-2.10.2 

This error does not emerge on GitHub since now we're using actions and it installs the 1.26.0 anyway I'd like you to consider my proposition, thanks

github-actions[bot] commented 1 year ago

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.