[16.0][IMP] base_edifact: improve method map2odoo_product to take pia segment into account

OCA / edi

GNU Affero General Public License v3.0

116 stars 299 forks source link

[16.0][IMP] base_edifact: improve method map2odoo_product to take pia segment into account #990

Closed trisdoan closed 1 week ago

trisdoan commented 1 month ago

This change

Improve map2odoo_product() to process pia segment (if provided). The codes is later used to find products in business.document.import:_match_product_search()
Before this change, users cannot import sale order when barcode and product code are both provided in edifact file and product,in Odoo, does not contain barcode.

Result

Import with non-existing code
Import with skipping error

OCA-git-bot commented 1 month ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

cyrilmanuel commented 2 weeks ago

Hiii @simahawk all good for you ?

simahawk commented 1 week ago

/ocabot merge patch

OCA-git-bot commented 1 week ago

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-990-by-simahawk-bump-patch, awaiting test results.

OCA-git-bot commented 1 week ago

Congratulations, your PR was merged at 20ba506346a5b5d29cd3e8055a63640cfebff9e1. Thanks a lot for contributing to OCA. ❤️