OCA / event

Event Management addons
GNU Affero General Public License v3.0
62 stars 166 forks source link

[16.0][ADD] website_event_ticket_limit: new module #388

Closed remi-filament closed 4 months ago

remi-filament commented 4 months ago

This module allows to configure the maximum number of tickets that a user can buy at once.

pedrobaeza commented 4 months ago

Why not taking the occasion to override the maximum 10 limit?

remi-filament commented 4 months ago

Why not taking the occasion to override the maximum 10 limit?

Hi @pedrobaeza thank you for looking into this. Good question, I guess you could have bad UX if one would register more than 10 tickets. Maybe we could set number to max_ticket if different than 0 and keep 10 max if max_ticket = 0 (same default behaviour as Odoo one).

Let me know if you think this would be pertinent, I could update template to reflect that !

pedrobaeza commented 4 months ago

OK, that sounds reasonable. Just document it in the README saying that this "limit" can serve to overpass standard 10 limit, putting a higher limit, hehe.

remi-filament commented 4 months ago

Done

remi-filament commented 4 months ago

Thanks @pedrobaeza for your review. Regarding the size of select, it is because of the content I suppose (before you were not allowed to have more than 9, so that data inside selection always had only 1 figure length, now if you can get more than 9 you then have some selection with 2 figures inside so the selection is bigger...)

remi-filament commented 4 months ago

Thanks @pedrobaeza I have implemented your comments !

pedrobaeza commented 4 months ago

Great, already approved.

pedrobaeza commented 4 months ago

On the README there's still a reference to the old field label.

OCA-git-bot commented 4 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

pedrobaeza commented 4 months ago

/ocabot merge nobump

OCA-git-bot commented 4 months ago

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-388-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 4 months ago

Congratulations, your PR was merged at e5cfbc77d02a833d525ce51781a3838cd6ad1f0a. Thanks a lot for contributing to OCA. ❤️