Closed remi-filament closed 4 months ago
Why not taking the occasion to override the maximum 10 limit?
Why not taking the occasion to override the maximum 10 limit?
Hi @pedrobaeza thank you for looking into this. Good question, I guess you could have bad UX if one would register more than 10 tickets. Maybe we could set number to max_ticket if different than 0 and keep 10 max if max_ticket = 0 (same default behaviour as Odoo one).
Let me know if you think this would be pertinent, I could update template to reflect that !
OK, that sounds reasonable. Just document it in the README saying that this "limit" can serve to overpass standard 10 limit, putting a higher limit, hehe.
Done
Thanks @pedrobaeza for your review. Regarding the size of select, it is because of the content I suppose (before you were not allowed to have more than 9, so that data inside selection always had only 1 figure length, now if you can get more than 9 you then have some selection with 2 figures inside so the selection is bigger...)
Thanks @pedrobaeza I have implemented your comments !
Great, already approved.
On the README there's still a reference to the old field label.
This PR has the approved
label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
/ocabot merge nobump
This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-388-by-pedrobaeza-bump-nobump, awaiting test results.
Congratulations, your PR was merged at e5cfbc77d02a833d525ce51781a3838cd6ad1f0a. Thanks a lot for contributing to OCA. ❤️
This module allows to configure the maximum number of tickets that a user can buy at once.