search

OCA / geospatial

Odoo and GIS
http://oca.github.io/geospatial/index.html
GNU Affero General Public License v3.0
189 stars 284 forks source link

[ADD] base_geolocalize_company #312

Closed legalsylvain closed 2 years ago

legalsylvain commented 2 years ago

Trivial Module.

This module extends the base_geolocalize odoo module, to add Geolocalization on Companies (res.company) level.

It adds a new tab named 'Company Assignation' and allow to enter manually (or automatically via the 'Geolocate' button) latitude and longitude.

This module is only useful in a multi-company context.

res_company_form

Usefull to use the new module web_view_leafltet_map. (https://github.com/OCA/geospatial/pull/310)

Note : Travis is failing because 12.0 is red. Please review : https://github.com/OCA/geospatial/pull/311

legalsylvain commented 2 years ago

/ocabot rebase

OCA-git-bot commented 2 years ago

Sorry @legalsylvain you are not allowed to rebase.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

dreispt commented 2 years ago

/ocabot merge nobump

OCA-git-bot commented 2 years ago

This PR looks fantastic, let's merge it! Prepared branch 12.0-ocabot-merge-pr-312-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot commented 2 years ago

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 12.0-ocabot-merge-pr-312-by-dreispt-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

yvaucher commented 2 years ago

@legalsylvain can you solve the lint?

base_geolocalize_company/models/res_company.py:11:89: E501 line too long (141 > 88 characters)
base_geolocalize_company/models/res_company.py:12:89: E501 line too long (144 > 88 characters)
base_geolocalize_company/models/res_company.py:13:62: E231 missing whitespace after ','
base_geolocalize_company/models/res_company.py:13:89: E501 line too long (130 > 88 characters)
base_geolocalize_company/models/res_company.py:16:1: W391 blank line at end of file
legalsylvain commented 2 years ago

@dreispt, @yvaucher : all is green. Can be merged.

OCA-git-bot commented 2 years ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

dreispt commented 2 years ago

/ocabot merge nobump

OCA-git-bot commented 2 years ago

What a great day to merge this nice PR. Let's do it! Prepared branch 12.0-ocabot-merge-pr-312-by-dreispt-bump-nobump, awaiting test results.

OCA-git-bot commented 2 years ago

Congratulations, your PR was merged at e1ada0cffe31d9323ca236bdd824b84409a322b9. Thanks a lot for contributing to OCA. ❤️