search

OCA / geospatial

Odoo and GIS
http://oca.github.io/geospatial/index.html
GNU Affero General Public License v3.0
187 stars 281 forks source link

[16.0][mig] web_view_leaflet_map and web_view_leaflet_map_partner #342

Closed legalsylvain closed 9 months ago

legalsylvain commented 1 year ago

res_partner_map

legalsylvain commented 1 year ago

/ocabot migration web_view_leaflet_map_partner

legalsylvain commented 1 year ago

/ocabot migration web_view_leaflet_map

github-actions[bot] commented 10 months ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

PaulGoubert commented 10 months ago

Hello @legalsylvain and thank you for this PR.
FYI, doing a functionnal review, and this working fine til trying to "group by" where I've an error "Uncaught Promise > Cannot read properties of undefined (reading 'lat')"

legalsylvain commented 9 months ago

hi @PaulGoubert . Nice catch ! I disabled the button "group by" (that makes no sense in a map context).

Could you test again, and update your review ?

thanks !

PaulGoubert commented 9 months ago

LGTM. Thank you @legalsylvain

legalsylvain commented 9 months ago

/ocabot merge patch

OCA-git-bot commented 9 months ago

Sorry @legalsylvain you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

legalsylvain commented 9 months ago

/ocabot rebase

OCA-git-bot commented 9 months ago

Sorry @legalsylvain you are not allowed to rebase.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

legalsylvain commented 9 months ago

geospacial maintainers : could you merge this one ? Thanks ! @yvaucher, @lmignon

pedrobaeza commented 9 months ago

Merging due to existing reviews:

/ocabot merge nobump

OCA-git-bot commented 9 months ago

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-342-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 9 months ago

Congratulations, your PR was merged at 22435d15dda4ea6fa8d22e9de697a10ef4e8a121. Thanks a lot for contributing to OCA. ❤️