OCA / helpdesk

Odoo modules for managing a HelpDesk system
GNU Affero General Public License v3.0
146 stars 314 forks source link

[16.0][IMP]helpdesk_mgmt: interface improvements #586

Open flotho opened 4 months ago

flotho commented 4 months ago

Depends on :

Backend Improvements :

Portal improvements :

flotho commented 4 months ago

Purpose is to boost the user experience backend : image

image

some improvements inspired from https://github.com/OCA/helpdesk/pull/556 . @eLBati how do you want me to mention it ?

flotho commented 4 months ago

Regarding the portal, multiple things could be imporved as proposed there : https://github.com/OCA/helpdesk/pull/577 It looks difficut to proper alter/inherit portal_docs_entry to add the button as proposed by @pedrobaeza So my proposal is to use css to grow on all the line : image

flotho commented 4 months ago

Ive also changed the view list : image

eLBati commented 4 months ago

how do you want me to mention it ?

Hi @flotho you could cherry-pick the commit, if applicable

flotho commented 4 months ago

Hi @eLBati , thanks, I'll do another try since dependencies have nbeen merged

flotho commented 4 months ago

how do you want me to mention it ?

Hi @flotho you could cherry-pick the commit, if applicable

cherry pick done

flotho commented 4 months ago

Hi @eLBati ,

Your review will be appreciated

Regards

flotho commented 3 months ago

Hi @eLBati @DorianMAG @gaelTorrecillas , @JulienMartinez , any review here would be appreciated

flotho commented 3 months ago

Hi @marcelsavegnago , your review would be appreciated here as it impacts the portal

flotho commented 3 months ago

pop @JulienMartinez , your review is expected here

flotho commented 3 months ago

hum.... @pedrobaeza ould you help me regarding the codecov? Looks like only readme is concerned. Do I have to reset the readme file ?

Regards

flotho commented 3 months ago

hum, the codecov failed on a the commit https://github.com/OCA/helpdesk/commit/bc8e7407a66c01b0adf4cd4ef5e869534dc092cd that is part of a post merge commit

flotho commented 3 months ago

hum, the codecov failed on a the commit bc8e740 that is part of a post merge commit

sorry to buzz @pedrobaeza , how can I get out from this situation, the codecov regression has been generated by a robot commit. In this case, what is the procedure ? Regards

pedrobaeza commented 3 months ago

Don't get mad with that, as:

  1. Codecov check is not mandatory. It's just a metric, but it doesn't block the merge.
  2. In my experience, it's not working well, giving false reds.
pedrobaeza commented 3 months ago

Please squash 1st, 2nd and 4th commit together, as they are not adding value as separated.

flotho commented 2 months ago

Please squash 1st, 2nd and 4th commit together, as they are not adding value as separated.

done! thanks @pedrobaeza

flotho commented 2 months ago

no more conflicts !