[16.0][FIX] helpdesk_mgmt: Tag tests as per recommendations for HttpCase type tests.

OCA / helpdesk

Odoo modules for managing a HelpDesk system

GNU Affero General Public License v3.0

146 stars 314 forks source link

[16.0][FIX] helpdesk_mgmt: Tag tests as per recommendations for HttpCase type tests. #588

Closed blaskurain closed 3 months ago

blaskurain commented 4 months ago

The tests of helpdesk_mgmt derived from HttpCase fail when we run them together with some personal addons. Tagging the tests as @tagged("post_install", "-at_install") as recommended [1] by Odoo fixes the issue without any downside.

[1] https://www.odoo.com/documentation/16.0/developer/reference/backend/testing.html#special-tags

pedrobaeza commented 4 months ago

Totally! Please put a proper commit message according guidelines, including the module name and an initial line a bit shorter, that you can expand later in subsequent lines:

https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

pedrobaeza commented 3 months ago

Can you please rebase the branch instead of doing a pull and adding an undesired commit?

pedrobaeza commented 3 months ago

/ocabot merge patch

OCA-git-bot commented 3 months ago

This PR looks fantastic, let's merge it! Prepared branch 16.0-ocabot-merge-pr-588-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 3 months ago

Congratulations, your PR was merged at a5bfe07d094330f6baf5f6e9a493cf7356b88895. Thanks a lot for contributing to OCA. ❤️