search

OCA / helpdesk

Odoo modules for managing a HelpDesk system
GNU Affero General Public License v3.0
151 stars 318 forks source link

[16.0][FIX] helpdesk_mgmt_timesheet: Apply the required attrs to the project_id field which has groups #631

Closed victoralmau closed 1 month ago

victoralmau commented 2 months ago

Apply the required attrs to the project_id field which has groups

despues

Please @pedrobaeza and @pilarvargas-tecnativa can you review it?

@Tecnativa

pedrobaeza commented 1 month ago

IMO what you should do is to swap the order on the helpdesk_mgmt_project instead, and a guideline must be to put always the visible field in first place.

victoralmau commented 1 month ago

IMO what you should do is to swap the order on the helpdesk_mgmt_project instead, and a guideline must be to put always the visible field in first place.

Sorry for not clarifying this earlier. The change you suggest does not work (although it applies the attrs to the corresponding field, it does not indicate by interface that it is required), for that reason I have done this change.

pedrobaeza commented 1 month ago

/ocabot merge minor

OCA-git-bot commented 1 month ago

On my way to merge this fine PR! Prepared branch 16.0-ocabot-merge-pr-631-by-pedrobaeza-bump-minor, awaiting test results.

OCA-git-bot commented 1 month ago

Congratulations, your PR was merged at 594c487cf17f9196c947adfbd0147fbc69bd74bf. Thanks a lot for contributing to OCA. ❤️