search

OCA / hr-attendance

HR Attendance OCA modules for Odoo
GNU Affero General Public License v3.0
50 stars 119 forks source link

[15.0][FIX] hr_attendance_report_theoretical_time: tests #105

Closed chienandalu closed 1 year ago

chienandalu commented 1 year ago

Tests rely on removing tz from the current user and it isn't possible anymore after https://github.com/odoo/odoo/commit/d6f2437e9ce69a585c33940c6a2c18f4a6c7fdad#diff-38469def2f870bb866f971f57797dd7c21b6a95d52a8eae72f832f0eea2434f9R105

pedrobaeza commented 1 year ago

That was put for test resilience, so the reason why it was put will arise again on one point. Do you know why it was put using git blame?

chienandalu commented 1 year ago

It goes all the way back here but I couldn't find out the reason why it was needed originally: https://github.com/OCA/hr/pull/465/commits/7c38f50973b0dbd0ee3de49ad39792535dafa032

Tardo commented 1 year ago

Maybe someone put it in thinking that changing to False would force times to be displayed in UTC?

OCA-git-bot commented 1 year ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 15.0-ocabot-merge-pr-105-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 1 year ago

Congratulations, your PR was merged at 3f1ffcb17b235a0a96e61ac2d1121a80db5d9685. Thanks a lot for contributing to OCA. ❤️