[15.0][MIG] hr_attendance_sheet: Migration to 15.0

OCA / hr-attendance

HR Attendance OCA modules for Odoo

GNU Affero General Public License v3.0

50 stars 119 forks source link

[15.0][MIG] hr_attendance_sheet: Migration to 15.0 #114

Closed albig closed 1 year ago

max3903 commented 1 year ago

/ocabot migration hr_attendance_sheet

OCA-git-bot commented 1 year ago

Sorry @max3903 you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

max3903 commented 1 year ago

@sbidoul I am not sure why but I don't have the permissions to set labels, milestones or reviewers or use ocabot in this repo. Can you help?

max3903 commented 1 year ago

@albig Can you add more tests to increase code coverage? Thank you

sbidoul commented 1 year ago

I am not sure why but I don't have the permissions to set labels, milestones or reviewers or use ocabot in this repo. Can you help?

Hi @max3903, it seems you are not part of the Human Resources PSC, this explains that.

max3903 commented 1 year ago

@dreispt Can you help? @patrickrwilson Are you interested to join the HR PSC? @albig I don't mind being removed as a maintainer of this module.

nimarosa commented 1 year ago

/ocabot migration hr_attendance_sheet

Tardo commented 1 year ago

I have a few questions:

Why are the theoretical hours not computed against the employee's attendance calendar?
Why is the hr.attendance.overtime model not used to calculate the overtime?

albig commented 1 year ago

Thanks @Tardo for your good questions.

I don't have the answers, because I haven't developped this module.

Why are the theoretical hours not computed against the employee's attendance calendar?

That's what I expected, too. This implementation is too basic but maybe I don't get the use case.

Why is the hr.attendance.overtime model not used to calculate the overtime?

For sure, because hr.attendance.overtime was introduced with Odoo 15 and this module arrived in this OCA repository in version 14 (maybe much older?).

Tardo commented 1 year ago

That's what I expected, too. This implementation is too basic but maybe I don't get the use case.

I would say that it is done this way in order to be able to create sheets with different calendars (hours). I think this should be handled by another module that allows you to define attendance calendars by dates.

This is an important change and depends on this new module. I don't know what people think about making this effort... or if any changes are open for discussion.

For sure, because hr.attendance.overtime was introduced with Odoo 15 and this module arrived in this OCA repository in version 14 (maybe much older?).

I would say that an effort should be made to switch to using this new model.

Perhaps, as they are changes in the operation of the module, it would be interesting to make a new module that changes the operation of this one and leave this one as it is.

Related module: hr_contract_employee_calendar_planning

github-actions[bot] commented 1 year ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

albig commented 1 year ago

We do not follow this approach anymore.