OCA / hr-attendance

HR Attendance OCA modules for Odoo
GNU Affero General Public License v3.0
50 stars 119 forks source link

[ADD] hr_attendance_overtime_from_work_calendar #139

Closed hbrunn closed 1 year ago

hbrunn commented 1 year ago

This module replaces Odoo core's overtime calculation with one that satisfies the expectation:

overtime = (time recorded in hr.attendance records) - (expected working hours as per working calendar)

for every given day.

Note this is a draft and as of yet rather an invitation for discussion. The rough idea is:

Currently this is super slow, but _compute_missing_overtime can be sped up considerably with some sql and a bit more convoluted grouping. It might also be worthwhile to have a start date for recalculations that admins can move forward periodically.

Further plan is to add hr_attendance_overtime_from_work_calendar_demo that depends on hr_holidays + hr_holidays_public and adds a bunch of (corner) test cases for this, and fix whatever comes out there.

albig commented 1 year ago

Thank you for this work.

Just some notes after my first testing:

hbrunn commented 1 year ago

we can have what this does simpler and less invasive with https://github.com/OCA/hr-attendance/pull/140 and https://github.com/OCA/hr-holidays/pull/87