OCA / hr-attendance

HR Attendance OCA modules for Odoo
GNU Affero General Public License v3.0
48 stars 117 forks source link

[IMP] hr_attendance_validation: Ignoring some leave types #155

Closed petrus-v closed 2 months ago

petrus-v commented 11 months ago

we are using hr.leaves to manage allowed remote days but we don't want to remove thoses times in attendance validation

github-actions[bot] commented 4 months ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

rafaelbn commented 2 months ago

Hello @OCA/human-resources-maintainers , please could you reopen this PR?

Thank you! 🙏🏼 Regards 😄 ❤️

rafaelbn commented 2 months ago

Hello @petrus-v ,

I you are the author of this module, you can add your self as maintainter so you can merge your self

Do you know about it?

Regards ✋🏼

rafaelbn commented 2 months ago

Sorry for noise, @nimarosa could you reopen and merge?

nimarosa commented 2 months ago

/ocabot rebase

@rafaelbn lets rebase first so we check the tests passes. Then we can merge.

OCA-git-bot commented 2 months ago

Congratulations, PR rebased to 14.0.

nimarosa commented 2 months ago

/ocabot merge minor

@petrus-v @rafaelbn please after merge cherry peak this PR to other versions so we maintain same functionality in all versions.

OCA-git-bot commented 2 months ago

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-155-by-nimarosa-bump-minor, awaiting test results.

OCA-git-bot commented 2 months ago

Congratulations, your PR was merged at 35ea8b81b60baef90a358fcee81badabc8c14d1c. Thanks a lot for contributing to OCA. ❤️

petrus-v commented 2 months ago

Thanks @rafaelbn to make this merge possible !

Yes, sometimes I try to put myself as maintainer but I've never use the ocabot command yet ! I've to read a bit more about it to feel confident to merge stuff !