Closed Saran440 closed 10 months ago
@yboujraf It still red because test script is not cover. you can help me to add test script and push it to this PR.
Dear @Saran440 Never done but if you tell me where I will double check it.
Best Regards,
@yboujraf Fixed, can you check it again please?
Is anyone could merge it ?
Dear @Saran440
I have installed the hr_expense_journal on my dev platform and
Will wait for the merge
Thanks again
Anybody could merge the migration ?
Dear @Saran440 Who could merge the migration ? I am still using the migration branch. I am expecting to use from branch 15.0. BR
@Saran440 , @Freni-OSI Pls, Anyone could merge this repo ? BR
@yboujraf if you're tested and it work. Could you approve this PR please?
Dear @Saran440
I confirm the PR is working for V15.0. Please would you like to merge.
Best Regards, Youssef
@yboujraf we need 2 person approved for merge.
May be you please approved this PR by go to Files changed > Review changes > Approve
Dear
Done. Hope to use the released version soon and pls take a look for migration to 16.0 as well.
Best Regards Youssef
From: Saran @ Ecosoft @.> Sent: Friday, October 6, 2023 12:06 To: OCA/hr-expense @.> Cc: BY-SYSTEMS SRL Boujraf Youssef @.>; Mention @.> Subject: Re: [OCA/hr-expense] [15.0][MIG] hr_expense_journal (PR #180)
@yboujrafhttps://github.com/yboujraf we need 2 person approved for merge.
May be you please approved this PR by go to Files changed > Review changes > Approve [Selection_008]https://user-images.githubusercontent.com/20896369/273175280-b683f859-0be1-48f1-9a65-328099020aaf.png [Selection_009]https://user-images.githubusercontent.com/20896369/273175291-c30cdf68-051b-40d2-8f7e-d98cb4b8d31f.png
— Reply to this email directly, view it on GitHubhttps://github.com/OCA/hr-expense/pull/180#issuecomment-1750332867, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABO5YWWVJWLVZRRKV2QZVC3X57J3DAVCNFSM6AAAAAAX7DHLOKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJQGMZTEOBWG4. You are receiving this because you were mentioned.Message ID: @.***>
Dear @Saran440
Could you check why "runboat/build" is pending ?
Best Regards
/ocabot merge nobump
What a great day to merge this nice PR. Let's do it! Prepared branch 15.0-ocabot-merge-pr-180-by-Saran440-bump-nobump, awaiting test results.
Congratulations, your PR was merged at c9e3d772cf9a7f371a95c3ffd9a6b2139d94628b. Thanks a lot for contributing to OCA. ❤️
Dear @Saran440 Don't know how to help for fixing those errors
Best Regards,