search

OCA / hr-expense

Human Resources Expenses OCA modules for Odoo
GNU Affero General Public License v3.0
50 stars 103 forks source link

[16.0][FIX] hr_expense_invoice: Incorrect data and check when creating vendor bill from expense #249

Closed pedrobaeza closed 1 day ago

pedrobaeza commented 2 months ago

Two fixes:

  1. The "amount_total" field now reflects the total of the invoice including taxes, so we have to use "untaxed_amount".
  2. If changing any data in the linked vendor bill, the computed fields used for the comparison are not yet recomputed, so let's do the check on a later stage (after the write).

Fixes #245

@Tecnativa

edlopen commented 2 months ago

Hello @pedrobaeza , can you reset de runboat so we can test it? Thank you!

pedrobaeza commented 2 months ago

Re-pushed

rafaelbn commented 2 months ago

FIX : https://github.com/OCA/hr-expense/issues/248

@moduon MT-5202 Please @edlopen @Gelojr could you review 😄 ❤️

Shide commented 2 days ago

@pedrobaeza can I continue this PR in a separate PR using your code (and mentioning you)?

pedrobaeza commented 2 days ago

We can merge this one and you add an extra PR on top of it. These fixes are welcome although not completed.

pedrobaeza commented 1 day ago

/ocabot merge patch

OCA-git-bot commented 1 day ago

What a great day to merge this nice PR. Let's do it! Prepared branch 16.0-ocabot-merge-pr-249-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 1 day ago

Congratulations, your PR was merged at f787c47f60934b6bd7b39d41d65ea4eb82f36b41. Thanks a lot for contributing to OCA. ❤️

pedrobaeza commented 1 day ago

@loida-vm was that test done before or after I performed the change that @Shide suggested?

loida-vm commented 1 day ago

It was this morning, after the change

pedrobaeza commented 1 day ago

Well, then the patch suggested by @Shide seems to be not working in that case.

Shide commented 1 day ago

@loida-vm I'll fix your second case soon.

loida-vm commented 1 day ago

Ok, thank you very much. Aside from that case, the PR works correctly.