search

OCA / hr-expense

Human Resources Expenses OCA modules for Odoo
GNU Affero General Public License v3.0
50 stars 103 forks source link

[17.0][MIG] hr_expense_advance_clearing #255

Closed hongquangminh closed 1 month ago

hongquangminh commented 2 months ago

Module migrated to version 17.0

214

pedrobaeza commented 2 months ago

Thanks for the contribution.

Please preserve commit history following technical method explained in https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-17.0.

If the jump is between several versions, you have to modify the source branch in the main command to accommodate it to this circumstance.

Please also check the red CIs.

hongquangminh commented 1 month ago

/ocabot migration hr_expense_advance_clearing

OCA-git-bot commented 1 month ago

Sorry @hongquangminh you are not allowed to mark the addon tobe migrated.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

Saran440 commented 1 month ago

@hongquangminh Hi, Thank you for your contribution. I think you forgot to use git format-patch before migrating. The history should be shown in this PR.

However, we use this module in our project. May I migrate it instead of you (I am starting the migration to version 17)? Could you help us review it, please?

hongquangminh commented 1 month ago

@hongquangminh Hi, Thank you for your contribution. I think you forgot to use git format-patch before migrating. The history should be shown in this PR.

However, we use this module in our project. May I migrate it instead of you (I am starting the migration to version 17)? Could you help us review it, please?

Hi @Saran440 , yes please, because I need this module for my business in version 17. And I don't see any migrated PR in this Repo. So that is why I am pushing this PR for official review. As you suggested, I will close this PR and wait for your session. Please ping me if you need to. Thanks!