[17.0][MIG] hr_expense_invoice: Migration to 17.0

desdelinux commented 3 months ago

Actions performed:

Deprecated hr.expense.reference field as part of 1.
Merged the hr.expense.is_editable and hr.expense.sheet_is_editable fields as part of 1.
Renamed hr.expense.unit_amount to hr.expense.price_unit.
Renamed hr.expense.attachment_number to hr.expense.nb_attachment.
Renamed hr.expense.approve_expense_sheets() to hr.expense.action_approve_expense_sheets().
Renamed hr.expense.account_move_id to hr.expense.account_move_ids.
Renamed hr.expense.total_amount to hr.expense.total_amount_currency.
Inherit compute of hr.expense.sheet.state to consider expenses with linked invoices.
Switched from old %-based string formatting to f-strings.
Replaced the use of attrs in views with their equivalent Python expressions as part of 2.
Adapted the hr.expense.sheet records creation in tests.
Updated to use the employee partner from hr.employee.work_contact_id instead of hr.employee.address_home_id since it has been split into multiple fields.
Added the hr.expense.amount_residual field to maintain the one invoice per expense functionality.
Adapted test assertions for hr.expense.sheet.state since it is now a computed field.

OCA-git-bot commented 2 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

desdelinux commented 2 months ago

Hi @chienandalu @pedrobaeza @LoisRForgeFlow

This is ready :)

desdelinux commented 2 months ago

Hi @gurneyalex @Saran440 this is ready.

Could you merged, please

moylop260 commented 2 months ago

/ocabot merge nobump

OCA-git-bot commented 2 months ago

Sorry @moylop260 you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

moylop260 commented 2 months ago

/ocabot merge nobump

OCA-git-bot commented 2 months ago

Sorry @moylop260 you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

pedrobaeza commented 2 months ago

/ocabot migration hr_expense_invoice

xmglord commented 2 months ago

@pedrobaeza @luisg123v all comments were applied, please review again.

xmglord commented 2 months ago

@luisg123v please review

xmglord commented 2 months ago

@pedrobaeza friendly reminder

xmglord commented 1 month ago

Hi @pedrobaeza

In v16 was not possible to have the smart button since the field related to it was a one2many field but in this version is possible and I already add it. Could you please test it functionally again?

xmglord commented 1 month ago

@pedrobaeza friendly reminder

OCA-git-bot commented 1 month ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 17.0-ocabot-merge-pr-256-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 1 month ago

Congratulations, your PR was merged at 38e6859ca23e07c89ff2156b15bc4f34c8b60f44. Thanks a lot for contributing to OCA. ❤️

OCA / hr-expense

[17.0][MIG] hr_expense_invoice: Migration to 17.0 #256