search

OCA / hr-expense

Human Resources Expenses OCA modules for Odoo
GNU Affero General Public License v3.0
50 stars 103 forks source link

[16.0][FIX] hr_expense_advance_clearing: visible analytic #259

Closed Saran440 closed 1 week ago

Saran440 commented 1 month ago

This PR delete code invisible analytic. I can't remember why we invisible analytic in advance?

What do you think? @kittiu

OCA-git-bot commented 1 month ago

Hi @kittiu, some modules you are maintaining are being modified, check this out!

douglascstd commented 1 week ago

Hi @Saran440,

When using advances, we cannot debit or credit an analytic account because the advance is not considered an expense. If we debit an analytic account for the advance and later use it to offset an expense with an analytic account, it results in two debits. Therefore, the analytic account should be nullified.

There is an error (possibly needing another PR to address): If the analytic account field is filled and then changed to an advance, the content of the field remains.

Saran440 commented 1 week ago

@douglascstd Thank you for the explanation. I will move it back to customize module.

and the issue you mentioned, if it still error please open and add step here https://github.com/OCA/hr-expense/issues