[14.0][IMP] hr_expense_invoice: prepare invoice values

OCA / hr-expense

Human Resources Expenses OCA modules for Odoo

GNU Affero General Public License v3.0

50 stars 103 forks source link

[14.0][IMP] hr_expense_invoice: prepare invoice values #265

Closed kaynnan closed 3 weeks ago

kaynnan commented 1 month ago

cc @marcelsavegnago @douglascstd @WesleyOliveira98

The purpose of this PR is to separate the invoice values for use in a _prepare method. In cases where modifications are made to specific move_line only, it would be necessary to rewrite a significant amount of code. Therefore, using _prepare would facilitate this process.

kaynnan commented 1 month ago

@pedrobaeza, Can you review please?

kaynnan commented 4 weeks ago

Could you create a prepare_invoice_line_values too?

Change implemented. Thank you for the suggestion, @mileo.

pedrobaeza commented 4 weeks ago

/ocabot merge patch

kaynnan commented 3 weeks ago

@pedrobaeza Do I need to do a rebase for the merge to occur? Apparently the bot didn't return something

pedrobaeza commented 3 weeks ago

/ocabot merge patch

OCA-git-bot commented 3 weeks ago

On my way to merge this fine PR! Prepared branch 14.0-ocabot-merge-pr-265-by-pedrobaeza-bump-patch, awaiting test results.

OCA-git-bot commented 3 weeks ago

Congratulations, your PR was merged at 66db007a2af8a362790931fb34a34869fa88b5e0. Thanks a lot for contributing to OCA. ❤️