search

OCA / hr-holidays

Human Resources Holidays OCA modules for Odoo
GNU Affero General Public License v3.0
36 stars 107 forks source link

[17.0][FW] hr_holidays_public: Deprecate use of employee_id in favour of partner_id #111

Open grindtildeath opened 9 months ago

grindtildeath commented 9 months ago

Helper functions to find public holidays did allow to use an hr.employee to filter country and states based on the employee address.

Since only the address of the employee was used, modifying the functions to use a res.partner instead of an hr.employee allows more possibilities such as checking public holidays for customers and suppliers.

Forward port of:

github-actions[bot] commented 2 months ago

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

pedrobaeza commented 1 week ago

/ocabot merge major

OCA-git-bot commented 1 week ago

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 17.0-ocabot-merge-pr-111-by-pedrobaeza-bump-major, awaiting test results.

OCA-git-bot commented 1 week ago

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-111-by-pedrobaeza-bump-major.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

pedrobaeza commented 1 week ago

Please rebase and check the CI.