search

OCA / hr-holidays

Human Resources Holidays OCA modules for Odoo
GNU Affero General Public License v3.0
35 stars 106 forks source link

[17.0][ADD] resource_calendar_get_days #138

Open xaviedoanhduy opened 1 month ago

xaviedoanhduy commented 1 month ago

The original development of this module has been done by Mint System. It can be found in: https://github.com/Mint-System/Odoo-Apps-HR/tree/15.0/resource_calendar_get_days This module has been ported to the OCA with their agreement, cc @janikvonrotz

- Supersedes: https://github.com/OCA/hr-holidays/pull/129

leemannd commented 1 month ago

Hello @janikvonrotz , your formal acceptation into the PR is welcome. @xaviedoanhduy When opening such new PRs would it be possible to gently ask a review from the author of the module?

pedrobaeza commented 1 month ago

Another question is about the module name, as singular forms are advisable: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#modules

janikvonrotz commented 1 month ago

Same questions as the other PR about Mint grant / CLA sign and the module name.

I signed the CLA and support the migration.

pedrobaeza commented 1 month ago

Yes, great. The module name is the only remaining thing.

leemannd commented 1 month ago

Hello @pedrobaeza I must confess that on this case, the naming using the plural dosen't bother me. The override done within the scope of this module is about the field and methods: days & _get_days_data

Maybe a better name could be resource_calendar_get_days_data_company , which in the other hand is super long. Do you have a proposition on this topic?

pedrobaeza commented 1 month ago

Well, the description on the README is not very related: Show remaining leaves per employee in allocation overview., so I have no clue...