[17.0][MIG] hr_contract_currency

OCA / hr

Odoo Human Resources Addons

GNU Affero General Public License v3.0

218 stars 667 forks source link

[17.0][MIG] hr_contract_currency #1357

Open baptiste-n42 opened 4 months ago

baptiste-n42 commented 4 months ago

Migration to v17:

[Issue] #1291

Work done :

[x] Update manifest version
[x] Add thai localization
[x] Update view form
[x] Add warning if using this module with Odoo accounting enterprise enabled
[x] ~~Add the custom currency to Odoo Payslips (If hr_payroll is installed)~~

baptiste-n42 commented 2 months ago

@peluko00 @mpascuall Can you please review ?

OCA-git-bot commented 2 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

baptiste-n42 commented 1 month ago

LGTM, tested in runboat. Is it planned to port a version 16 as well?

I think the migration to v16 could be very easy since the module is fairly small and not that complex.

Do we have a timeline for merging the PR in the stable branch ?

pleirb commented 1 month ago

LGTM, tested in runboat. Is it planned to port a version 16 as well?

I think the migration to v16 could be very easy since the module is fairly small and not that complex.

Do we have a timeline for merging the PR in the stable branch ?

Yes, that's what I did, I ported this version for v16 but ran into a lot of difficulties with several dependent modules as a comment in issue #167. How did you resolve the multiple currency issue so you could post accounting entries correctly in version 17?

baptiste-n42 commented 1 month ago

How did you resolve the multiple currency issue so you could post accounting entries correctly in version 17?

I didn't.. This module is only for reference, if you're posting in a journal you will use the journal's currency. I don't think you can have a multi-currency journal system, Odoo will just convert foreign currency to the journal currency based on the latest rate.

baptiste-n42 commented 3 weeks ago

@peluko00 @mpascuall how can I add this module to issue #1291 modules list ?

mpascuall commented 3 weeks ago

@peluko00 @mpascuall how can I add this module to issue #1291 modules list ?

Hi! You can check this link that contains the information you need: https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

baptiste-n42 commented 3 weeks ago

Hi! You can check this link that contains the information you need: https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

Hi, yes I read it. So do you need to add this module to the list for this PR to be merged ?

peluko00 commented 3 weeks ago

Hi! You can check this link that contains the information you need: https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

Hi, yes I read it. So do you need to add this module to the list for this PR to be merged ?

The PSC will add it when review it, don't worry abou that.