search

OCA / hr

Odoo Human Resources Addons
GNU Affero General Public License v3.0
219 stars 672 forks source link

[17.0][MIG] hr_course: Migration to 17.0 #1367

Closed DorianMAG closed 3 months ago

DorianMAG commented 5 months ago

supersedes https://github.com/OCA/hr/pull/1306

DorianMAG commented 5 months ago

thanks @DorianMAG , looks like it's no more possible to add attendees in session. this line seems to be responsible https://github.com/OCA/hr/pull/1367/files#diff-62b3dcbd5bf33b0a29e9a3c017fa5b24dcc1fb9cfffbd2e28af9582e8599a7d1R55

could you have a look ?

Thx for the review, it's now fix Regards

OCA-git-bot commented 5 months ago

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

flotho commented 4 months ago

hi @OCA/human-resources-maintainers any chance to have a merge here ?

OCA-git-bot commented 3 months ago

The migration issue (#1291) has not been updated to reference the current pull request because a previous pull request (#1306) is not closed. Perhaps you should check that there is no duplicate work. CC @manishkumarbohra

OCA-git-bot commented 3 months ago

On my way to merge this fine PR! Prepared branch 17.0-ocabot-merge-pr-1367-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot commented 3 months ago

Congratulations, your PR was merged at 2ad0382843ddcc7b380f8e2d47e4d3025e331f12. Thanks a lot for contributing to OCA. ❤️

pedrobaeza commented 3 months ago

/ocabot migration hr_course