[17.0][FIX] hr_employee_second_lastname: removed useless mapped address_home_id

OCA / hr

Odoo Human Resources Addons

GNU Affero General Public License v3.0

219 stars 672 forks source link

[17.0][FIX] hr_employee_second_lastname: removed useless mapped address_home_id #1370

Open DorianMAG opened 5 months ago

DorianMAG commented 5 months ago

Remove useless mapped. The source code has changed in OCB/OdooSA. The relational field no longer exists on the address in V17. https://github.com/OCA/OCB/blob/3afef8250c829406a8fd227a6bd9f71c4f80ff29/addons/hr/models/hr_employee.py#L49

OCA-git-bot commented 5 months ago

Hi @luisg123v, some modules you are maintaining are being modified, check this out!

DorianMAG commented 5 months ago

Regarding commit message:

* Title doesn't conform guidelines

* Missing commit description

Besides, regarding PR description:

* Not clear enough, why the OCB should affect? This should work with mnative Odoo

* Link is not a permalink

Hi @luisg123v Thank you for your review. The commit description is corrected. I updated my message regarding the OCB/OdooSA source code. Updating the link with a permalink.

Regards

DorianMAG commented 5 months ago

If the partner_firstname module is installed, this makes it impossible to install this module, because the address_home_id field no longer exists in v17, and it is replaced by a non-relational field which therefore no longer returns a recordset partner

flotho commented 4 months ago

Hi @luisg123v , any chance to have a new review here ?

DorianMAG commented 4 days ago

Missing commit description.

Please rebase to see if CI is fixed.

Done regards