[13.0][FIX] hr_employee_document: Remove record rules from hr.employee to avoid side effects

victoralmau commented 5 months ago

Remove record rules from hr.employee to avoid side effects.

Example of use case:

An employee X is created and a Manager Y (parent_id) is defined.
User X creates an expense report (hr.expense.sheet).
The "Submit to manager" button is clicked.
A permissions error is displayed when accessing employee Y (hr.employee) because the record rules that this module had added do not allow access to that record.

Solution: This change overrides some things to allow the user's employee attachments to be displayed.

Please @pedrobaeza can you review it?

@Tecnativa TT49736

pedrobaeza commented 5 months ago

/ocabot merge major

OCA-git-bot commented 5 months ago

This PR looks fantastic, let's merge it! Prepared branch 13.0-ocabot-merge-pr-1372-by-pedrobaeza-bump-major, awaiting test results.

OCA-git-bot commented 5 months ago

Congratulations, your PR was merged at 72fd297d7d12bb63c485220b872e1fc4fda89a8c. Thanks a lot for contributing to OCA. ❤️

OCA / hr